1502280 - Remove the case BinTokenReaderBase.errorReporter_ is null

Status: RESOLVED FIXED

(Core :: JavaScript Engine, enhancement, P3)

Description

[Tooru Fujisawa [:arai]]

https://searchfox.org/mozilla-central/rev/e0c879c86b95bdc752b1dbff6088169735674e4a/js/src/frontend/BinTokenReaderBase.cpp#37
> ErrorResult<JS::Error&>
> BinTokenReaderBase::raiseError(const char* description)
> {
>     MOZ_ASSERT(!cx_->isExceptionPending());
>     if (MOZ_LIKELY(errorReporter_)) {
>         errorReporter_->reportErrorNoOffset(JSMSG_BINAST, description);
>     } else {
>         // Only true in testing code.
> ...

This should be removed in order to introduce better error reporting methods.

Comment 1

[Tooru Fujisawa [:arai]]

Attachment: Remove the case BinTokenReaderBase.errorReporter_ is null

Removed the `!errorReporter_` case, and added dummy ErrorReporter to the test.
Currently the testcase doesn't test error case, so the dummy reporter crashes if error reporting methods are called.

Comment 2

[David Teller [:Yoric] - still alive but not very active]

Comment on attachment 9023158 [details] [diff] [review]
Remove the case BinTokenReaderBase.errorReporter_ is null

Review of attachment 9023158 [details] [diff] [review]:
-----------------------------------------------------------------

::: js/src/jsapi-tests/testBinTokenReaderTester.cpp
@@ +36,5 @@
>  #if defined(XP_UNIX)
>  
>  #include <sys/param.h>
>  
> +class DummyErrorReporter : public js::frontend::ErrorReporter

Could you document what this dummy error reporter is for?

Also, shouldn't this be out of the `#if defined(XP_UNIX)`?

Comment 3

[Tooru Fujisawa [:arai]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/9b456742a2cc22f56aac2a4d26063307b85135a6
Bug 1502280 - Remove the case BinTokenReaderBase.errorReporter_ is null. r=Yoric

Comment 4

[Tooru Fujisawa [:arai]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/d3f4d556a89d3e5e72749314a0cf81d942fafc13
Bug 1502280 - followup: Fix non-unified build. r=bustage

Comment 5

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/9b456742a2cc
https://hg.mozilla.org/mozilla-central/rev/d3f4d556a89d