1502501 - Conditionally show "Return to AMO" instead of StartupOverlay for FxA sign-in on about:welcome

Status: VERIFIED FIXED

(Firefox :: Messaging System, enhancement, P1)

Description

[Ursula Sarracini (:ursula)]

I think we have the go-ahead to remove the FxA sign-in page that is currently on about:welcome. Kate and I briefly chatted and we agreed that it would be good to keep about:welcome around since it's useful for targeting purposes, and just re-purpose that page for return to AMO messaging and onboarding messaging. 
We will soon have a new FxA onboarding card via bug 1501817 that we can leverage now that we will be removing the FxA sign-in page on about:welcome

Comment 1

[Alex Davis [:adavis]]

My understanding was that traffic would continue to go to the about:welcome page w/ FxA on it.

However, users that were bucketed into the new AMO flow would not be sent to it. And only in this case would they see an FxA card on the New Tab onboarding overlay.

Tim, did I misunderstand something? I'm super cool with the experiment because the loss of logins and registrations relating to the AMO experiment is minimal but I was not under the impression about:welcome would change for everyone else too.

If the intention is to move FxA to one of those cards permanently, my ask is that it be A/B tested first (against about:welcome) because I believe it will have a really negative impact on FxA logins and registrations.

Comment 2

[Tim Spurway [:tspurway]]

Hey :adavis - sorry for the crossed lines - my mistake.

Ok.  Let's leave the FxA based about:welcome, and 'replace' it with the Return-to-AMO experience only when the attribution indicates they came from an AMO page.

Sorry for the confusion!

Comment 3

[Alex Davis [:adavis]]

No worries Tim. We both misunderstood each other.


In the meantime, I excitedly await future collaboration around experimenting with alternatives to about:welcome. It's going to be a tough one but there are a lot of UR, UT and A/B results to educate future directions for that experience.

Comment 4

[GitHub Bugzilla PR Linker]

Attachment: Link to GitHub pull-request: https://github.com/mozilla/activity-stream/pull/4558

Comment 5

[[github robot]]

Commit pushed to master at https://github.com/mozilla/activity-stream

https://github.com/mozilla/activity-stream/commit/7bc6efe57257e6527fe57d79fbb171f482d41646
Fix Bug 1502501 - Conditionally show StartupOverlay for FxA sign-in on about:welcome (#4558)

Comment 6

[Ed Lee :Mardak]

https://hg.mozilla.org/mozilla-central/rev/945c7e99ee1f

Comment 7

[Vlad Jiman]

I've verified that the new overlay is shown, however I have a question, is the opacity of the 'modalOverlayOuter active' overlay supposed to be lower than 1.0? In the mockups I've seen, background images/text cannot be noticed. Thanks!

Comment 8

[Ursula Sarracini (:ursula)]

The background of the onboarding overlay is meant to be slightly transparent, yes. You can see the spec here: https://mozilla.invisionapp.com/share/XFOQD3H23YE#/screens/327208697_Card_Variants and you'll notice the background is visible through the overlay. This bug was only meant to introduce some logic as a set up for bug 1475354, and nothing should be different than the existing behaviour. The opacity hasn't changed since the onboarding overlay landed back in bug 1432676

Comment 9

[Vlad Jiman]

Thank you Ursula. 
Verified using Firefox 65.0a1 running on Windows 10 x64 and BUG 1501817's 7th comment states that it was also verified and passed testing on Mac 10.13 and Arch Linux 4.16.

Comment 10

[Vlad Jiman]

We've encountered a problem on this bug on some test machines so if it's okay I will re-open it, it looks like it might be related to profiles as all of the testers used the same nightly build (20181128220334). 

In some cases, the first page shown was the blue sign-in-page and could only access the onBoarding tour after pressing skip this step, however on my test machine I was unable to reproduce it until a fresh reinstall of FF.

Steps:
Install a fresh nightly build from the official mozilla page
Create a new profile and start-up the browser
Enter the about:welcome in the url bar

Expected:
The on boarding overlay should be shown at first startup

Actual:
The sign-in page is shown.

Comment 11

[Ursula Sarracini (:ursula)]

The sign in page is always supposed to be shown, I'm not sure what the problem is? As I mentioned before, this bug doesn't involve any of the UI for Return to AMO - it only changed some of the internals for getting it set up. The onboaring tour should always be shown under the blue sign in page after pressing skip this step, so this sounds like it's working as intdended

Comment 12

[Vlad Jiman]

Thanks for your reply, will mark as this bug verified if this is as expected.