1502772 - WinUtils::WriteBitmap should use BITMAPV4HEADER (v4+ header)

Status: RESOLVED FIXED

(Core :: Widget: Win32, defect)

Description

[Makoto Kato [:m_kato]]

Native toast notification uses WinUtils::WriteBitmap to bitmap for notification now.  Since it uses old BITMAPINFOHEADER structure, it doesn't support alpha.  So some notification bitmap's background color is black, not transparent.

Comment 1

[Makoto Kato [:m_kato]]

s/to bitmap/to write bitmap/

Comment 2

[Makoto Kato [:m_kato]]

Attachment: Bug 1502772 - WinUtils::WriteBitmap should use BITMAPV4HEADER (v4+ header)

Native toast notification uses WinUtils::WriteBitmap to bitmap for notification now.  Since it uses old BITMAPINFOHEADER structure, it doesn't support alpha.

So I would like to support alpha value to WinUtils::WriteBitmap.

Comment 3

[Timothy Nikkel (:tnikkel)]

Would it be better to use the encoder that's in imagelib and get rid of this code?

Comment 4

[Makoto Kato [:m_kato]]

(In reply to Timothy Nikkel (:tnikkel) from comment #3)
> Would it be better to use the encoder that's in imagelib and get rid of this
> code?

Yes, it is nice that imagelib has encoder that saves bitmap v4+.  Notification and setting wallpaper use this utility method.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5fce19a3307f
WinUtils::WriteBitmap should use BITMAPV4HEADER (v4+ header) r=aklotz

Comment 6

[Eliza Balazs [:ebalazs_]]

https://hg.mozilla.org/mozilla-central/rev/5fce19a3307f

Comment 8

[Ryan VanderMeulen [:RyanVM]]

Is this something we should consider uplifting to Beta or can it ride the trains?

Comment 9

[Ryan VanderMeulen [:RyanVM]]

Answering my own question, this is still only enabled on Nightly builds, so I'm going to say no to that question.