1502821 - browser.urlbar.suggest.bookmark false is no longer respected

Status: VERIFIED FIXED

(Firefox :: Address Bar, defect, P2)

Description

[evedaneeltrevize]

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:63.0) Gecko/20100101 Firefox/63.0

Steps to reproduce:

Have bookmarked sites, and don't have them in your history.

Uncheck Options > Privacy & Security > Address Bar > When using the address bar, suggest: Bookmarks. Or set browser.urlbar.suggest.bookmark false in about:config

(Update from FF 62 to FF 63).


Actual results:

Start typing the bookmarked site in the address bar, and notice that it suggests the bookmarked site, despite the setting not to use bookmarks as a suggestion source.


Expected results:

Bookmarks should not be used as a suggestion source while this setting is false/uncheked, bookmarked sites should not be revealed and presented when typing in the address bar.

Comment 1

[22erne]

New Firefox version no longer uses moz_hosts, instead it suggests host from moz_origins. With this change, it ignores setting "Suggest from Bookmarks" and autocompletes url. It also seems to ignore or bypass frecency, still suggests at negative values.

Comment 2

[Marco Bonardo [:mak]]

It's likely a fallback from bug 1488879 and bug 1493636

Comment 3

[evedaneeltrevize]

This bug is still present in 64.0

Comment 4

[Mark Banner (:standard8)]

Thanks for the update, but there's really no need to update titles/bugs for each version. This is a P1 issue and we'll hopefully get to it soon.

Comment 6

[evedaneeltrevize]

Might I enquire why this has been downgraded in priority? It's still leaking all bookmarks into the URL bar despite an explicit menu option to not do so.

Comment 7

[Marco Bonardo [:mak]]

Because the team is really busy, so we plan to fix it asap, but we have no resources to fix it "now". Bookmarks are not a top tier privacy information, as such it's not a critical issue. If you have ideas on how to fix the bug, we'll gladly accept suggestions in shape of a code patch.

Comment 9

[Drew Willcoxon :adw]

Attachment: Bug 1502821 - Don't autofill bookmarks when browser.urlbar.suggest.bookmark is false.

• Add a new case for when suggest.bookmark = false to the logic that returns the appropriate SQL query
• Add a bunch of new tests that cover all cases

Comment 10

[Drew Willcoxon :adw]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=ff06da4e34926a5051c3fee47d4c26df75a1ead1

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a0d1724c35aa
Don't autofill bookmarks when browser.urlbar.suggest.bookmark is false. r=mak

Comment 12

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/a0d1724c35aa

Comment 13

[Ryan VanderMeulen [:RyanVM]]

Is this something we should consider uplifting to Beta for Fx69 or can it ride Fx70 to release?

Comment 14

[Drew Willcoxon :adw]

I think it would be OK to uplift. I'll request approval.

Comment 15

[Drew Willcoxon :adw]

Comment on attachment 9078842 [details]
Bug 1502821 - Don't autofill bookmarks when browser.urlbar.suggest.bookmark is false.

Beta/Release Uplift Approval Request

• User impact if declined: This bug has been present since 63, so it's not a critical uplift.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: Please see comment 0, but note that when it says "suggest", it means autofill (i.e., the text in the input is automatically filled in with a domain name as you are typing)
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): We're handling a case that wasn't previously handled and not changing anything else. Has lots of automated tests.
• String changes made/needed: None

Comment 16

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9078842 [details]
Bug 1502821 - Don't autofill bookmarks when browser.urlbar.suggest.bookmark is false.

Fixes a bug causing the browser.urlbar.suggest.bookmark pref to not be respected. Adds new automated test coverage. Approved for 69.0b9.

Comment 17

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/9f40d7849c3a

Comment 18

[Vlad Lucaci, Thunderbird QA (:vlucaci)]

Reproduced from 62.0.3 (buildID:20181001155545) -> 64.0a1 (buildID:20180915220059)

Confirming as verified fixed on Nightly 70.0a1 (buildID:20190729213839) and 69.0b9 (buildID:20190730004747) with Win 10x64, Ubuntu 18.04 and macOS 10.13