1502910 - Remove TimelineActor usage from netmonitor

Status: RESOLVED FIXED

(DevTools :: Netmonitor, enhancement, P2)

Description

[Alexandre Poirot [:ochameau] [PTO back August 21]]

https://searchfox.org/mozilla-central/rev/8848b9741fc4ee4e9bc3ae83ea0fc048da39979f/devtools/client/netmonitor/src/connector/firefox-connector.js#137-144
The netmonitor instantiate the Timeline front without using target.getFront here.
But this code is for backward compatiblity against FF45, which we no longer support, so this code should be removed.

Then, it looks like the TimeLineActor is no longer used anywhere but tests, so we may be able to also remove it.

Comment 1

[Alexandre Poirot [:ochameau] [PTO back August 21]]

Attachment: Bug 1502910 - Stop using the timeline actor from netmonitor.

MozReview-Commit-ID: 3GWeJDDfUyG

Comment 2

[Alexandre Poirot [:ochameau] [PTO back August 21]]

Attachment: Bug 1502910 - Remove TimelineActor.

MozReview-Commit-ID: DtmS18EYw12

Depends on D10186

Comment 3

[Alexandre Poirot [:ochameau] [PTO back August 21]]

try run:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=535a6a8667ddeda15889ea6fbf218c0401f0e2db

I was wrong about FF45. The code to be removed is for FF45+ to 60.
But current oldest supported version is 62 (current release channel), so we can already remove this.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/36b7bb1dd72b
Stop using the timeline actor from netmonitor. r=Honza
https://hg.mozilla.org/integration/autoland/rev/bd20d4c37ba6
Remove TimelineActor. r=Honza

Comment 5

[Andrei Ciure[:aciure]]

https://hg.mozilla.org/mozilla-central/rev/36b7bb1dd72b
https://hg.mozilla.org/mozilla-central/rev/bd20d4c37ba6