1502947 - Add helper function to MozXULElement for inheriting attributes

Status: RESOLVED FIXED

(Toolkit :: UI Widgets, task, P3)

Description

[Brian Grinstead [:bgrins]]

We want this for a number of bugs, so I'm going to spin this out of Bug 1455433 and make a separate bug for it.

Comment 1

[alexander :surkov (:asurkov)]

Attachment: patch

Comment 2

[Brian Grinstead [:bgrins]]

Comment on attachment 9020977 [details] [diff] [review]
patch

Review of attachment 9020977 [details] [diff] [review]:
-----------------------------------------------------------------

Stealing review, looks good. Thanks Alex.

::: toolkit/content/tests/chrome/test_custom_element_base.xul
@@ +93,5 @@
> +    let el = document.querySelector("inherited-element");
> +    ok(el, "element exists");
> +
> +    is(el.label.getAttribute("foo"), "fuagra", "predefined attribute @foo");
> +    ok(!el.label.hasAttribute("boo"), "boo", "predefined attribute @boo");

Nit: the second parameter here should be removed (since this is `ok` and not `is`)

Comment 3

[Brian Grinstead [:bgrins]]

Attachment: inheritAttribute.patch

With nit addressed and commit message

Comment 4

[Brian Grinstead [:bgrins]]

Attachment: inheritAttribute.patch

Updated jsdoc comment to not reference attrs as an array

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/2596473d8286
Add helper function to MozXULElement for inheriting attributes;r=bgrins

Comment 6

[alexander :surkov (:asurkov)]

(In reply to Brian Grinstead [:bgrins] from comment #3)
> Created attachment 9021247 [details] [diff] [review]
> inheritAttribute.patch
> 
> With nit addressed and commit message

thank you!

Comment 7

[Andrei Ciure[:aciure]]

https://hg.mozilla.org/mozilla-central/rev/2596473d8286