1527680 - Come up with a more consistent pattern for inheriting attributes for MozElement Custom Elements

Status: RESOLVED FIXED

(Toolkit :: UI Widgets, task)

Description

[Brian Grinstead [:bgrins]]

Previous discussions about this can be seen in Bug 1502947 and Bug 1523429 and in the reviews of the patches there.

Current inheritAttribute helper: https://searchfox.org/mozilla-central/rev/cb7faaf6b4ad2528390186f1ce64618dea71031e/toolkit/content/customElements.js#63

Some examples of how we do this currently:

• Explicit (<menulist>): https://searchfox.org/mozilla-central/rev/cb7faaf6b4ad2528390186f1ce64618dea71031e/toolkit/content/widgets/menulist.js#376
• Map + explicit (autocomplete <richlistitem>): https://searchfox.org/mozilla-central/source/toolkit/content/widgets/autocomplete-richlistitem.js#82-114
• Map + [inherit] attribute (<popupnotification>): https://searchfox.org/mozilla-central/rev/cb7faaf6b4ad2528390186f1ce64618dea71031e/toolkit/content/widgets/popupnotification.js#44-60
  -- Note: works for content where we don’t nest more elements underneath that will also set [inherits], otherwise we’ll incorrectly map down to nested children. Wouldn’t be a problem with Shadow DOM

Having some kind of static map with type of <selector, <array<attribute>> would allow observedAttributes to be read by processing the map instead of having them declared separately. We'd have to sort out when to cache (and invalidate) the results of querySelector.

Comment 1

[Brian Grinstead [:bgrins]]

Attachment: Bug 1527680 - Add MozElement `inheritedAttributes` helper for automatically inheriting attributes based on a map of selectors to attributes

Comment 2

[:Paolo Amadini]

Attachment: Example rough code edits

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/66082f22ae11
Add MozElement `inheritedAttributes` helper for automatically inheriting attributes based on a map of selectors to attributes r=paolo

Comment 4

[Cosmin Sabou [:CosminS]]

Backed out for merge conflicts on toolkit/content/widgets/popupnotification.js!
Backout link: https://hg.mozilla.org/integration/autoland/rev/79d9076cbaa1c24ca96094e86706952951bb67f6

Comment 5

[Brian Grinstead [:bgrins]]

(In reply to Cosmin Sabou [:CosminS] from comment #4)

Backed out for merge conflicts on toolkit/content/widgets/popupnotification.js!
Backout link: https://hg.mozilla.org/integration/autoland/rev/79d9076cbaa1c24ca96094e86706952951bb67f6

Rebased and relanded

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/27280189b6fa
Add MozElement `inheritedAttributes` helper for automatically inheriting attributes based on a map of selectors to attributes r=paolo

Comment 7

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/27280189b6fa