Closed Bug 1503002 Opened 2 years ago Closed 2 years ago

Fix hal not initialized error when using dom.ipc.processPriorityManager.enabled

Categories

(Core :: DOM: Content Processes, enhancement)

enhancement
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla66
Tracking Status
firefox66 --- fixed

People

(Reporter: dthayer, Assigned: mconley)

References

Details

Attachments

(1 file)

Taking this for now.
Assignee: nobody → mconley
It looks like the wakelock stuff was added for b2g back in bug 999327, and ultimately what it appears to do now is set the mHighPriority boolean here:

https://searchfox.org/mozilla-central/rev/2e5e28f518524f8af5b158ddb605022b6a2d68cf/dom/ipc/ProcessPriorityManager.cpp#503,505

But that mHighPriority boolean doesn't appear to be used anywhere anymore. It _was_ used when bug 999327 originally landed, but stopped being used in bug 1119277.

I think we can just tear out this wakelock observer for the process priority manager for now, since it doesn't appear to be used by anyone (in particular, doesn't appear to be used by Fennec or GeckoView).
Yes, IIRC high-priority wakelocks were used exclusively for Firefox OS' dialer application so they're long gone.
The WakeLockObserver is being used to set a boolean that's never being read.

This also makes it so that dom.ipc.processPriorityManager.enabled can be set to
true by default. Without this patch, setting that pref to true by default means
that the WakeLockObserver attempts to be registered before Hal has had a chance
to initialize which causes an assertion failure.
Pushed by mconley@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/ec0c3354ab22
Don't register WakeLockObserver for ProcessPriorityManagerImpl. r=gsvelto
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla66
You need to log in before you can comment on or make changes to this bug.