1476981 - Turn on dom.ipc.processPriorityManager.enabled in Nightly

Status: RESOLVED FIXED

(Core :: DOM: Content Processes, enhancement)

Description

[Alex Thayer [:alexical] (she/her)]

baku, now that we have the ability to set process priorities on Windows, is the code from bug 1366356 in good enough shape to turn on in Nightly?

Comment 1

[Andrea Marchesini [:baku]]

Only on windows. On linux, when a process decreases its priority, it cannot set it back to the original value.

Comment 2

[randomreporter]

I've just created and set dom.ipc.processPriorityManager.enabled to true in about:config, Nightly 19-07-2018. After that the priority of WebExtensions process was set to low. I don't know if that's intended or not.

Comment 3

[Alex Thayer [:alexical] (she/her)]

Hmm, yeah that doesn't seem great. Additionally this seems to be causing xpcshell failures on try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=efe96043eb4ddaf528ec74dd02c140def6c99070&selectedJob=189008945

Comment 5

[Mike Conley (:mconley) (:⚙️)]

<mconley> jcristau: hey - suppose my team has something somewhat experimental that we wanted to turn on in Nightly to get user feedback. Can I assume it's too late in the 64 cycle to do that?

<jcristau> i think it's probably fine still
but now you have me curious about what it is :)

<mconley> jcristau: on Windows, we have a pref that will turn on the "background process priority manager" - this thing will downgrade the process priority of tabs running in the background
so, presumably, this will free up cycles for the foreground

<jcristau> mconley: cool.  sounds fine to me if you want to turn that on with #ifdef NIGHTLY_BUILD.

Comment 6

[Mike Conley (:mconley) (:⚙️)]

jcristau gave us the go ahead to try this out in 64 behind the NIGHTLY_BUILD ifdef! Feel like taking this on?

Comment 7

[Alex Thayer [:alexical] (she/her)]

Attachment: Bug 1476981 - Turn on dom.ipc.processPriorityManager.enabled in Nightly r?mconley

Comment 8

[Alex Thayer [:alexical] (she/her)]

(It looks like bug 1476250 changed the initialization of some dependencies, which is breaking my try runs. Working on sorting that out.)

Comment 9

[Mike Conley (:mconley) (:⚙️)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=d14e2018da31f80265b0cf03c5ab5d93efc802ab

Comment 10

[Mike Conley (:mconley) (:⚙️)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=ecaa86ef24dfaa07611b53cdd353828b133d2ab2

Comment 11

[Mike Conley (:mconley) (:⚙️)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=f6d4aa0578d61947b7478cb7e19ccdd7145f4dd8

Comment 12

[Mike Conley (:mconley) (:⚙️)]

Snagging this with dthayer's permission. Let's see if we can get this into Nightly.

Comment 13

[Mike Conley (:mconley) (:⚙️)]

Attachment: Bug 1476981 - Turn on the process priority manager on Nightly on Windows. r?dthayer

Comment 14

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/905f08f4eab0
Turn on the process priority manager on Nightly on Windows. r=dthayer

Comment 15

[Stefan Hindli [:stefan_hindli]]

https://hg.mozilla.org/mozilla-central/rev/905f08f4eab0