1503028 - Mach boostrap requires git, which isn't present in MozillaBuild

Status: NEW

(Firefox Build System :: Bootstrap Configuration, defect)

Description

[Thomas Daede [:TD-Linux]]

Attachment: mach bootstrap error

Following the instructions at the following URL doesn't work: https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/Build_Instructions/Windows_Prerequisites

In particular, mach bootstrap now requires git, but no directions to install git are provided.

Comment 1

[Mike Hommey [:glandium]]

This is where the error happens:
  File "c:\users\mozilla\gecko-dev\python/mozversioncontrol\mozversioncontrol\__init__.py", line 460, in get_repository_object
    return GitRepository(path, git=git)

This is what the full corresponding code looks like:

    if os.path.isdir(os.path.join(path, '.hg')):
        return HgRepository(path, hg=hg)
    elif os.path.exists(os.path.join(path, '.git')):
        return GitRepository(path, git=git)
    else:
        raise InvalidRepoPath('Unknown VCS, or not a source checkout: %s' %
                              path)

IOW, it means there is no .hg directory in the directory you ran mach boostrap from, and there is a .git file or directory in it. Which under normal circumstances, would mean you have done a git clone, and thus, have git.

Comment 2

[Thomas Daede [:TD-Linux]]

Ah yeah, I did this on a gecko-dev clone (because cloning mozilla-central was extremely slow on this machine).

I guess this can be a wontfix. It would be nice if start-shell.bat could pull in an existing git install automatically, though.

Comment 3

[Gary Kwong [:gkw] [:nth10sd] (NOT official MoCo now)]

It would be nice if start-shell.bat could pull in an existing git install automatically, though.

See bug 1253212.

Comment 4

[Tom Ritter [:tjr]]

I hit this today also: I'm trying to set up moz-phab on a Windows machine; and it assumes git is in the system path and available to set up arcanist.

Comment 5

[Māris Fogels [:mars] (please needinfo)]

:tjr the moz-phab setup instructions are a known issue, see bug 1574008.