1503132 - Run offline MSG thread even when not rendering

Status: RESOLVED FIXED

(Core :: Web Audio, enhancement, P2)

Description

[Karl Tomlinson (:karlt)]

This is necessary to process events for AudioWorklet (which may run JS) on the same thread as JS is running during rendering.

https://treeherder.mozilla.org/#/jobs?repo=try&revision=54eeba1e2378c32553c9e187f5c0e0852c4b7f35

Comment 1

[Karl Tomlinson (:karlt)]

Attachment: Bug 1503132 remove unused MediaStream::ConsumerCount() r?padenot

MozReview-Commit-ID: 2y6b7sP1vJZ

Comment 2

[Karl Tomlinson (:karlt)]

Attachment: Bug 1503132 remove unused MediaStreamGraphImpl::Running() r?padenot

MozReview-Commit-ID: 1QKFopM8qIV

Depends on D10159

Comment 3

[Karl Tomlinson (:karlt)]

Attachment: Bug 1503132 remove unnecessary monitor notify for AudioCallbackDriver r?padenot

MozReview-Commit-ID: CHudtPp66BC

Depends on D10160

Comment 4

[Karl Tomlinson (:karlt)]

Attachment: Bug 1503132 remove unnecessary SystemClockDriver::mWaitState r?padenot

mWaitState is only ever tested against WAITSTATE_WAITING_INDEFINITELY and so
the other values are equivalent.  It is never WAITSTATE_WAITING_INDEFINITELY
on leaving (or entering) WaitForNextIteration and so there is no need to set
it in WakeUp().

Depends on D10161

Comment 5

[Karl Tomlinson (:karlt)]

Attachment: Bug 1503132 add wait/wake-up support to OfflineAudioContext r?padenot

Depends on D10162

Comment 6

[Karl Tomlinson (:karlt)]

Attachment: Bug 1503132 update offline main thread state when there is no pending iteration r?padenot

Depends on D10163

Comment 7

[Karl Tomlinson (:karlt)]

Attachment: Bug 1503132 when graph time has not advanced, only ensure another iteration if rendering r?padenot

Depends on D10164

Comment 8

[Karl Tomlinson (:karlt)]

Attachment: Bug 1503132 do not shut down graph thread on completion of offline rendering r?padenot

AudioWorket will need to keep processing events on the graph thread.
The graph thread is instead shut down when the AudioContext is destroyed.

Depends on D10165

Comment 9

[Karl Tomlinson (:karlt)]

Attachment: Bug 1503132 remove unused ProcessedMediaStream::QueueFinish() r?padenot

Depends on D10166

Comment 10

[Karl Tomlinson (:karlt)]

Attachment: Bug 1503132 initialize mEndTime to zero for offline graphs r?padenot

This will prevent rendering from starting when the graph thread is started
before StartNonRealtimeProcessing() is called.

Depends on D10167

Comment 11

[Karl Tomlinson (:karlt)]

Attachment: Bug 1503132 create offline graph thread on receipt of the first message r?padenot

With this change, the graph is already running when mEndTime is set and so
this must be done on the graph thread for consistent ordering with in-flight
messages.

Depends on D10168

Comment 12

[Karl Tomlinson (:karlt)]

Attachment: Bug 1503132 make RoundUpToEndOfAudioBlock() a static member r?padenot

Depends on D10169

Comment 13

[Karl Tomlinson (:karlt)]

Attachment: Bug 1503132 remove special-case sync dispatch for not-started offline RunAfterPendingUpdates() r?padenot

Depends on D10170

Comment 14

[Karl Tomlinson (:karlt)]

Attachment: Bug 1503132 remove mNonRealtimeProcessing r?padenot

Depends on D10171

Comment 15

[Karl Tomlinson (:karlt)]

Attachment: Bug 1503132 remove unused HasAudioOutput() r?padenot

Depends on D10172

Comment 16

[Karl Tomlinson (:karlt)]

Attachment: Bug 1503132 don't add audio output to offline streams r?padenot

Depends on D10173

Comment 17

[Karl Tomlinson (:karlt)]

Attachment: Bug 1503132 delay creation of offline graph and stream that may not be required r?padenot

decodeAudioData() is a common OfflineAudioContext use case where the graph
is not required.

Depends on D10174

Comment 18

[Karl Tomlinson (:karlt)]

Attachment: Bug 1503132 remove unused function finish() r?padenot

Depends on D10175

Comment 19

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/981f31de3924
remove unused MediaStream::ConsumerCount() r=padenot
https://hg.mozilla.org/integration/autoland/rev/3fb0c8f6d6e2
remove unused MediaStreamGraphImpl::Running() r=padenot
https://hg.mozilla.org/integration/autoland/rev/3eca90e1af07
remove unnecessary monitor notify for AudioCallbackDriver r=padenot
https://hg.mozilla.org/integration/autoland/rev/7889d20e3a29
remove unnecessary SystemClockDriver::mWaitState r=padenot
https://hg.mozilla.org/integration/autoland/rev/543cac7034fe
add wait/wake-up support to OfflineAudioContext r=padenot
https://hg.mozilla.org/integration/autoland/rev/de7f45d6f032
update offline main thread state when there is no pending iteration r=padenot
https://hg.mozilla.org/integration/autoland/rev/7e9935a07eaf
when graph time has not advanced, only ensure another iteration if rendering r=padenot
https://hg.mozilla.org/integration/autoland/rev/61d08765489c
do not shut down graph thread on completion of offline rendering r=padenot
https://hg.mozilla.org/integration/autoland/rev/d9eda2382bd9
remove unused ProcessedMediaStream::QueueFinish() r=padenot

Comment 20

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ba172f2b086a
initialize mEndTime to zero for offline graphs r=padenot
https://hg.mozilla.org/integration/autoland/rev/2c97e4069615
create offline graph thread on receipt of the first message r=padenot
https://hg.mozilla.org/integration/autoland/rev/a1573c156ba1
make RoundUpToEndOfAudioBlock() a static member r=padenot
https://hg.mozilla.org/integration/autoland/rev/ec0336b4a1bf
remove special-case sync dispatch for not-started offline RunAfterPendingUpdates() r=padenot
https://hg.mozilla.org/integration/autoland/rev/90a9506812f6
remove mNonRealtimeProcessing r=padenot
https://hg.mozilla.org/integration/autoland/rev/5744145e9c7e
remove unused HasAudioOutput() r=padenot
https://hg.mozilla.org/integration/autoland/rev/89480ab36714
don't add audio output to offline streams r=padenot
https://hg.mozilla.org/integration/autoland/rev/821b04c10c0d
delay creation of offline graph and stream that may not be required r=padenot
https://hg.mozilla.org/integration/autoland/rev/9c23717ddc50
remove unused function finish() r=padenot

Comment 21

[Andrei Ciure[:aciure]]

https://hg.mozilla.org/mozilla-central/rev/981f31de3924
https://hg.mozilla.org/mozilla-central/rev/3fb0c8f6d6e2
https://hg.mozilla.org/mozilla-central/rev/3eca90e1af07
https://hg.mozilla.org/mozilla-central/rev/7889d20e3a29
https://hg.mozilla.org/mozilla-central/rev/543cac7034fe
https://hg.mozilla.org/mozilla-central/rev/de7f45d6f032
https://hg.mozilla.org/mozilla-central/rev/7e9935a07eaf
https://hg.mozilla.org/mozilla-central/rev/61d08765489c
https://hg.mozilla.org/mozilla-central/rev/d9eda2382bd9

Comment 22

[Arthur Iakab [arthur_iakab]]

https://hg.mozilla.org/mozilla-central/rev/ba172f2b086a
https://hg.mozilla.org/mozilla-central/rev/2c97e4069615
https://hg.mozilla.org/mozilla-central/rev/a1573c156ba1
https://hg.mozilla.org/mozilla-central/rev/ec0336b4a1bf
https://hg.mozilla.org/mozilla-central/rev/90a9506812f6
https://hg.mozilla.org/mozilla-central/rev/5744145e9c7e
https://hg.mozilla.org/mozilla-central/rev/89480ab36714
https://hg.mozilla.org/mozilla-central/rev/821b04c10c0d
https://hg.mozilla.org/mozilla-central/rev/9c23717ddc50