1513722 - Run AudioWorklet from offline MSG thread

Status: RESOLVED FIXED

(Core :: Web Audio, enhancement, P2)

Description

[Karl Tomlinson (:karlt)]

+++ This bug was initially created as a clone of Bug #1476514 +++

As discussed in Bug 1458448, all JS associated with the worklet global should
run on a single thread.  We'd like to run AudioWorkletProcessor.process()
calls from the MSG thread, and so that means that all JS will need to run from
the MSG thread.

Currently, the MSG often uses multiple threads (bug 1473469), but uses only a single thread for OfflineAudioContext.  That means that we can run JS for OfflineAudioContext.audioWorklet on the MSG thread without the need to wait for the solution to bug 1473469.  That enables the AudioWorklet implementation to be developed and tested in parallel with the solution to bug 1473469.

Comment 1

[Karl Tomlinson (:karlt)]

Attachment: bug 1513722 expose WorkletJSContext creation and deletion and delay creation until required r?baku

The on-demand creation from Worklet.addModule() provides the same creation
path for clients that provide their own thread.

Comment 2

[Karl Tomlinson (:karlt)]

Attachment: Bug 1513722 run AudioWorklet for OfflineAudioContext on MSG thread r?padenot

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0c454fd1dbcb
expose WorkletJSContext creation and deletion and delay creation until required r=baku
https://hg.mozilla.org/integration/autoland/rev/8e2c3015fc95
run AudioWorklet for OfflineAudioContext on MSG thread r=padenot

Comment 4

[Andreea Pavel [:apavel]]

Backed out for build bustages

Push with failure: https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=8e2c3015fc9538088195076a8ab0f36c3603cfdc

Failure log:  https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=218054018&repo=autoland&lineNumber=28027

Backout: https://hg.mozilla.org/integration/autoland/rev/0204dfb3145ffbb3b282259e1564bfddd514ff75

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8d5eac9cc761
expose WorkletJSContext creation and deletion and delay creation until required r=baku
https://hg.mozilla.org/integration/autoland/rev/934614ed9f72
run AudioWorklet for OfflineAudioContext on MSG thread r=padenot

Comment 6

[Eliza Balazs [:ebalazs_]]

https://hg.mozilla.org/mozilla-central/rev/8d5eac9cc761
https://hg.mozilla.org/mozilla-central/rev/934614ed9f72