Closed Bug 1503173 Opened 2 years ago Closed 2 years ago
Render bug, part of page blank at Homey Developer Documentation (developer
User Agent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/70.0.3538.77 Safari/537.36 Steps to reproduce: Steps: 1. Open Firefox 2. Navigate to `https://developer.athom.com/docs/apps` (be sure the zoom level is set to 100%) when you zoom to 200%, the page renders fully. Actual results: Part of the page is not rendered (see attachment) Expected results: The page should render like chromium renders it (see attachment)
eli5saado, Could you please re-test with Beta and Nightly? It seems to be fixed on Beta aand Nightly. ATTENTION: Please backup your profile folder before start them. The profile will be incompatible. https://www.mozilla.org/en-US/firefox/beta/all/ https://www.mozilla.org/en-US/firefox/nightly/all/
Fixed range: https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=6ef8cd81d40542b7319127fdb8be840ab16c4cd4&tochange=7845d51b6f3cd691ec3ec97061021f18cda74c0c Fixed by: Bug 1490890
Depends on: 1490890
I can still repro if I zoom in / out on Nightly. I need to head out now, but if somebody could find the regression range for that it'd be appreciated (doesn't need to be you if you can't Alice, you already do a lot!).
Status: UNCONFIRMED → NEW
Ever confirmed: true
so, Bug 1490890 only fix initial load. Layout is broken after zoom in/out. And re-loading page will fix.
I get this as the regression range: https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=c0f88b376e33&tochange=c18776175a69 Given the flexbox association from the kinda-fixed-by attribution in comment 2 (bug 1490890): in that range, I'd guess that this was a regression from bug 1054010.
Summary: Render bug, part of page blank → Render bug, part of page blank at Homey Developer Documentation (developer.athom.com)
Here's a reduced testcase that directly triggers the bad rendering. Basically, from the perspective of the outer (horizontal) flex container: this is a case where we're supposed to be considering its flex item to have a **definite size**, per Flexbox 9.8 category 3 (https://drafts.csswg.org/css-flexbox-1/#definite-sizes ). In this case, the flex item in question happens to be the (inner) vertical flex container. We're incorrectly behaving as if it has an indefinite size, which means we're not honoring "height:100%" on its own child.
As shown in the testcase, we actually get this correct if the item (the inner flex container) has "overflow:initial" (the default behavior). But we get it incorrect with "overflow: [hidden]" and probably any non-default value, presumably because it puts one more layer of separation between the percent-height thing and the container whose size we'd really like to resolve the percent against.
Anonymous boxes strike back? :-)
Indeed. Also, for extra confirmation: I tested the latest versions of Chrome, Safari, and Edge, and they all agree with each other on the attached testcase's rendering -- they make the lime boxes as tall as the container, covering up all the red that we show.
(In reply to Alice0775 White from comment #1) > eli5saado, > Could you please re-test with Beta and Nightly? It seems to be fixed > on Beta aand Nightly. > > ATTENTION: > Please backup your profile folder before start them. > The profile will be incompatible. > > https://www.mozilla.org/en-US/firefox/beta/all/ > https://www.mozilla.org/en-US/firefox/nightly/all/ Hi Alice, I could not test with nightly, as I did not have enough time to build it, for beta I found binaries in the AUR so I could test. When I initially load the page, it renders correctly, and everything works. However, when I zoom in and out part of the page disappears and turns gray/blank again. , Eli Saado
Too late for a fix in 63, but we could still take a patch for 65.
Priority: P2 → P3
Flags: needinfo?(svoisen) → needinfo?(dholbert)
Depends on: 1128354
Assignee: nobody → dholbert
Status: NEW → ASSIGNED
Pushed by firstname.lastname@example.org: https://hg.mozilla.org/integration/autoland/rev/40890267a589 When deciding whether a flex item needs a final reflow, check RELATIVE_BSIZE state bit on its children. r=emilio
You need to log in before you can comment on or make changes to this bug.