1503269 - The bookmark vertical separators are very difficult to select on Mac platform

Status: RESOLVED DUPLICATE of bug 1311103

(Firefox :: Bookmarks & History, defect, P3)

Description

[Vlad Lucaci, Thunderbird QA (:vlucaci)]

Attachment: Verical separators hard to select

[Affected versions]:
- 64.0b5
- 63.0
- 65.0a1

[Affected platforms]:
- macOS 10.13.6
- Mac OS X 10.10.5

[Steps to reproduce]:
1. Launch Firefox
2. Enable the bookmarks toolbar
3. Add some separators (by using the "New Separator" context menu option)
4. Move the separators anywhere in the bookmark toolbar.

[Expected result]:
- The separators can easily be selected and moved anywhere in the toolbar.

[Actual result]:
- The separators are extremely difficult to select and thus, the browser itself ends up moving with the cursor.

[Regression range]:
- Will return with regression range ASAP.

Comment 1

[Vlad Lucaci, Thunderbird QA (:vlucaci)]

Hello,

I have returned with a regression range:

https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=4403805b3b66f4a130f21d0d2ae036b8fc9d6f5b&tochange=e43f2f6ea111c2d059d95fa9a71516b869a69698

Hope it helps.

Comment 2

[:Gijs (he/him)]

(In reply to Vlad Lucaci (:vlucaci) from comment #0)
> Created attachment 9021187 [details]
> Verical separators hard to select

This video doesn't seem to be publicly viewable.

The regression window is quite broad. Is it possible to narrow it down further?

Moving to Bookmarks/History for now, but it's possible the regression is somewhere else... it's hard to tell from that window, as I don't see obvious suspects in theme/bookmarks/gfx code.

Comment 3

[Vlad Lucaci, Thunderbird QA (:vlucaci)]

Hello Gijs,

I will try to narrow down the regression range a little bit more .
In the meantime I won't clear the needinfo request.

Here is the video attachment again:
https://drive.google.com/file/d/1L0BwlDJvjGYATL-jeKwYtMsF7L_gj1U2/view?usp=sharing

Comment 4

[Vlad Lucaci, Thunderbird QA (:vlucaci)]

Hello guys, 

I tried to get a more narrowed regression range for this issue multiple times, and everytime got to the builds from 2016 ,with the same outcome. 

It seems that the separators were difficult to select ever since then. So I believe that this issue is actually not a regression.

Comment 5

[Liz Henry (:lizzard) (relman/hg->git project)]

Marking fix-optional for 65 and 66 so that these already triaged issues don't show up repeatedly in weekly regression triage. Happy to take a patch in nightly.

Comment 6

[Vlad Lucaci, Thunderbird QA (:vlucaci)]

The issue is still present with the same repro steps on 77.0b5 (ID:20200512163137) and 78.0a1(ID: 20200512212513) on macOS 10.15.4.

This renders this functionality to be almost unusable since out of 10 attemps only 2 were successful (to select the separator).

Comment 7

[Marco Bonardo [:mak]]

Yes, it's annoying, but there are workarounds, those same separators can be dragged in the Sidebar or the Library window.
It's probably matter of styling the vertical separators differently on Mac, maybe with some added padding and negative margin, so it's easier to target.

We also have another bug (that I can't find off-hand) where due to margin between bookmarks toolbar buttons, new bookmarks may be created in the wrong place (at the end of the overflow, instead of the point of click). The bookmarks toolbar buttons were supposed to not have margin, but someone added one. This to say the whole margin/padding situation on the bookmarks toolbar should be re-evaluated, but unfortunately it's not a priority for any team. I'd love if we'd have a users feedback&papercuts team.