1503286 - During a spell check before sending, double-clicking a suggested correctly spelled word no longer works

Status: RESOLVED FIXED

(Thunderbird :: Message Compose Window, defect)

Description

[Arthur K. (he/him)]

User Agent: Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:56.0) Gecko/20100101 Firefox/56.0 SeaMonkey/2.53

Steps to reproduce:

I have "Check Spelling Before Sending" enabled. Before sending an email, I will be prompted to correct any misspelled words. In 60.2.1 and before, I used to be able to double-click on a suggested correct spelling of a word in Spell Checker and it would accept and apply that word as the correct spelling of the misspelled word.


Actual results:

Double-clicking a suggested correct spelling of the word no longer works.


Expected results:

Double-clicking a suggested correct spelling of the word should work.  The functionality still works in the 2nd build of TB 60.3.0.

Comment 1

[Jorg K (CEST = GMT+2)]

I'm glad it still works in TB 60.3 ;-)

Confirmed in Daily 65. You don't need the "Check Spelling Before Sending", you can just hit the "Spelling" button. So STR:

Start a new message.
Type a few words with spelling mistakes.
Click on spelling.
Double-click a suggested correction.

Nothing happens but the suggested word should be accepted.

Alice, can you please find the regression for us.

Comment 2

[Richard Marti (:Paenglab)]

Maybe from listitem removal, bug 1435688.

Comment 3

[Alice0775 White]

Regression window:
https://hg.mozilla.org/comm-central/pushloghtml?fromchange=9edb2b29454bf76de263491e8635d65d955b7fdf&tochange=4e763866d18285694952a98b7849ed94cffb48c6
https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=f6df6a982ee9510ca32dd3afa52dfe9f8c3586a3&tochange=547144f5596c1a146b208d68d93950a6313080ca

Comment 4

[Jorg K (CEST = GMT+2)]

Richard, can you look into this one.

Comment 5

[Richard Marti (:Paenglab)]

When I double click the word I get this error:  ReferenceError: reference to undefined property "label"[Learn More] EdSpellCheck.xul:1:23 

I think this comes from here: https://searchfox.org/comm-central/source/editor/ui/dialogs/content/EdSpellCheck.js#152

Probably this needs some changes because the richlists work different to the listitems. But this is nothing I can do with my knowledge. Maybe Aceman or Geoff can help here.

Comment 6

[Alice0775 White]

FWIW, If I change as follows, then it works.

https://searchfox.org/comm-central/source/editor/ui/dialogs/content/EdSpellCheck.xul#63

-                   ondblclick="if (gAllowSelectWord) Replace(event.target.label);"/>
+                   ondblclick="if (gAllowSelectWord) Replace(this.selectedItem.label);"/>

Comment 7

[Jorg K (CEST = GMT+2)]

Let's go with Alice' suggestion. I'll make a patch.

Comment 8

[Jorg K (CEST = GMT+2)]

Attachment: 1503286-double-click.patch

Thanks Alice, putting this in your name.

Comment 9

[Jorg K (CEST = GMT+2)]

Attachment: 1503286-double-click.patch (v2)

Aceman told me over IRC that I should investigate this better. OK, event.target is the label now and that has a value. Let's go with that.

Comment 10

[:aceman]

Comment on attachment 9021668 [details] [diff] [review]
1503286-double-click.patch (v2)

Review of attachment 9021668 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks, works for me.

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/22fb120a634f
fix double-click in list of suggested words after bug 1475817. r=jorgk,aceman

Comment 12

[Jorg K (CEST = GMT+2)]

Beta (TB 64 beta 2):
https://hg.mozilla.org/releases/comm-beta/rev/593d228719d752e37377d322cced522032d3582b