Closed Bug 1503286 Opened 10 months ago Closed 10 months ago
During a spell check before sending, double-clicking a suggested correctly spelled word no longer works
User Agent: Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:56.0) Gecko/20100101 Firefox/56.0 SeaMonkey/2.53 Steps to reproduce: I have "Check Spelling Before Sending" enabled. Before sending an email, I will be prompted to correct any misspelled words. In 60.2.1 and before, I used to be able to double-click on a suggested correct spelling of a word in Spell Checker and it would accept and apply that word as the correct spelling of the misspelled word. Actual results: Double-clicking a suggested correct spelling of the word no longer works. Expected results: Double-clicking a suggested correct spelling of the word should work. The functionality still works in the 2nd build of TB 60.3.0.
I'm glad it still works in TB 60.3 ;-) Confirmed in Daily 65. You don't need the "Check Spelling Before Sending", you can just hit the "Spelling" button. So STR: Start a new message. Type a few words with spelling mistakes. Click on spelling. Double-click a suggested correction. Nothing happens but the suggested word should be accepted. Alice, can you please find the regression for us.
Maybe from listitem removal, bug 1435688.
Regression window: https://hg.mozilla.org/comm-central/pushloghtml?fromchange=9edb2b29454bf76de263491e8635d65d955b7fdf&tochange=4e763866d18285694952a98b7849ed94cffb48c6 https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=f6df6a982ee9510ca32dd3afa52dfe9f8c3586a3&tochange=547144f5596c1a146b208d68d93950a6313080ca
Richard, can you look into this one.
When I double click the word I get this error: ReferenceError: reference to undefined property "label"[Learn More] EdSpellCheck.xul:1:23 I think this comes from here: https://searchfox.org/comm-central/source/editor/ui/dialogs/content/EdSpellCheck.js#152 Probably this needs some changes because the richlists work different to the listitems. But this is nothing I can do with my knowledge. Maybe Aceman or Geoff can help here.
FWIW, If I change as follows, then it works. https://searchfox.org/comm-central/source/editor/ui/dialogs/content/EdSpellCheck.xul#63 - ondblclick="if (gAllowSelectWord) Replace(event.target.label);"/> + ondblclick="if (gAllowSelectWord) Replace(this.selectedItem.label);"/>
Let's go with Alice' suggestion. I'll make a patch.
Thanks Alice, putting this in your name.
Aceman told me over IRC that I should investigate this better. OK, event.target is the label now and that has a value. Let's go with that.
Comment on attachment 9021668 [details] [diff] [review] 1503286-double-click.patch (v2) Review of attachment 9021668 [details] [diff] [review]: ----------------------------------------------------------------- Thanks, works for me.
Pushed by firstname.lastname@example.org: https://hg.mozilla.org/comm-central/rev/22fb120a634f fix double-click in list of suggested words after bug 1475817. r=jorgk,aceman
Status: ASSIGNED → RESOLVED
Closed: 10 months ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.