Closed Bug 1503293 Opened 6 years ago Closed 2 years ago

"tran" gets autocompleted to "transition=7&sort=4/"

Categories

(Firefox :: Address Bar, defect, P5)

Product:
Firefox
Component:
Address Bar
Type:
defect
Points:
2

Tracking

()

Status:
RESOLVED FIXED
Milestone:
105 Branch
Tracking Flags:
Tracking Status
firefox-esr60 --- unaffected
firefox-esr91 --- wontfix
firefox-esr102 --- wontfix
firefox63 --- wontfix
firefox64 --- wontfix
firefox65 --- wontfix
firefox66 --- wontfix
firefox67 --- wontfix
firefox68 --- wontfix
firefox103 --- wontfix
firefox104 --- wontfix
firefox105 --- fixed

People

(Reporter: marco, Assigned: daisuke)

References

(Blocks 4 open bugs, Regression)

Details

(Keywords: papercut, regression, Whiteboard: [snt-scrubbed][search-papercut])

Attachments

(1 file)

Bug 1503293: Filter 'place' prefix from autofill.
48 bytes, text/x-phabricator-request
Details | Review
When I type "tran" in my address bar, I see "transition=7&sort=4/" in my address bar, with the first suggestion being "place:transition=7&sort=4".
Regression from bug 1493636.
Blocks: 1493636
status-firefox63: --- → affected
status-firefox64: --- → affected
status-firefox-esr60: --- → unaffected
Flags: needinfo?(adw)
Has Regression Range: --- → yes
Keywords: regression
uh, place: uris should never be suggested :(
Priority: -- → P1
Whiteboard: [fxsearch]
Assignee: nobody → adw
Status: NEW → ASSIGNED
Flags: needinfo?(adw)
It's probably because we ignore frecency, and place: uris have 0 frecency. Ideally they should also have the hidden field set, but looks like we miss doing that in some case, and it's likely related to the problem. hidden is the actual field for things that should not appear in autocomplete.
Updating tracking flags as we get closer to the 64 release, I am leaving the status for 64 to affected as this is triaged as a P1.
status-firefox63: fix-optional → wontfix
Priority: P1 → P2

Drew, will this get a fix to uplift to 67?

Flags: needinfo?(adw)

No

Flags: needinfo?(adw)
No longer blocks: 1493636
Regressed by: 1493636
Blocks: 1590487
Points: --- → 2
Priority: P2 → P3

Bug 1531335 may be a dupe of this one, but as comment 3 mentions, frecency may also be related in this bug and I think it's probably not in the other one.

See Also: → 1531335

On Firefox 78.0.2 I have this exact problem as in https://bugzilla.mozilla.org/show_bug.cgi?id=1542070 show up with "place:type=6&sort=14&maxresults=10" showing up when typing t. Clearing the history and bookmarks does not make it go away. Very annoying.

Keywords: papercut
See Also: 1531335 →

It looks like the problem is the query in the autofill provider (https://searchfox.org/mozilla-central/rev/70cf6863bd85af2a3188ec1fe5209a3ec1b2de86/browser/components/urlbar/UrlbarProviderAutofill.jsm) is not excluding pages with hidden=1 or frecency=0, that is the most common case for place: uris.
We have a frecency threshold but it is skipped for bookmarks.

Assignee: adw → nobody
Severity: normal → S4
Status: ASSIGNED → NEW
Priority: P3 → P5
Whiteboard: [fxsearch] → [snt-triaged][search-papercut]
Whiteboard: [snt-triaged][search-papercut] → [snt-scrubbed][search-papercut]
Assignee: nobody → daisuke
Status: NEW → ASSIGNED
Blocks: 1783977
Blocks: 1783980
Pushed by dakatsuka.birchill@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/814e0c46ac15 Filter 'place' prefix from autofill. r=adw

https://hg.mozilla.org/mozilla-central/rev/814e0c46ac15

Status: ASSIGNED → RESOLVED
Closed: 2 years ago
status-firefox105: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 105 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: