1503468 - Missing AUTO_PROFILER_THREAD_SLEEPs prevent duplication of profiler samples when thread is asleep

Status: RESOLVED FIXED

(Core :: Gecko Profiler, enhancement)

Description

[Gerald Squelart (he/him) (not at Mozilla since 2022-09-15)]

Breaking off from bug 1502998, which initially found that on Linux there is pretty much no duplication happening in content processes.

As per bug 1502998 comment 4, the initial fix for Windows, Mac, and Android is to add some missing AUTO_PROFILER_THREAD_SLEEPs around waits, which are already conveniently highlighted with IDLE markers.

However on Linux the problem looks quite different (too frequent sleep/wake cycles, which prevent duplications), and probably harder to fix.

So I will let bug 1502998 deal with that Linux issue. And this bug here can quickly add the missing SLEEPs.
Though once these are in place, we should check whether they suffer from too-frequent sleep/wake cycles as well (initial tests on my Windows machine showed an improvement in duplications, so I think it's a useful patch to land). I'll add a note in the other bug to follow-up on non-Linux platforms.

Comment 1

[Gerald Squelart (he/him) (not at Mozilla since 2022-09-15)]

Attachment: Bug 1503468 - Add more AUTO_PROFILER_THREAD_SLEEP's - r?mstange

These are around wait functions that already had an IDLE marker.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/07f248c9a47d
Add more AUTO_PROFILER_THREAD_SLEEP's - r=mstange

Comment 3

[Stefan Hindli [:stefan_hindli]]

https://hg.mozilla.org/mozilla-central/rev/07f248c9a47d