Closed Bug 1504347 Opened 4 years ago Closed 4 years ago

Missing AUTO_PROFILER_THREAD_SLEEPs in Necko prevent duplication of profiler samples when thread is asleep

Categories

(Core :: Gecko Profiler, enhancement)

enhancement
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla65
Tracking Status
firefox65 --- fixed

People

(Reporter: mozbugz, Assigned: mozbugz)

References

Details

Attachments

(1 file)

Would be good to get a profiler label with the IDLE category into these stacks as well, so that the thread category graph in the profiler will correctly show these threads as idle.
Attachment #9022406 - Attachment description: Bug 1504347 - Add AUTO_PROFILER_THREAD_SLEEP around Necko waits - r?mayhemer → Bug 1504347 - Add IDLE markers and AUTO_PROFILER_THREAD_SLEEP around Necko waits - r?mayhemer
Thanks for the suggestion Markus.
Pushed by gsquelart@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/15adeb85dc27
Add IDLE markers and AUTO_PROFILER_THREAD_SLEEP around Necko waits - r=mayhemer
https://hg.mozilla.org/mozilla-central/rev/15adeb85dc27
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla65
You need to log in before you can comment on or make changes to this bug.