Closed Bug 1504347 Opened 4 years ago Closed 4 years ago
_PROFILER _THREAD _SLEEPs in Necko prevent duplication of profiler samples when thread is asleep
47 bytes, text/x-phabricator-request
|Details | Review|
As suggested by :mayhemer in https://phabricator.services.mozilla.com/D10671#256902 Could we mark few more places in necko? https://searchfox.org/mozilla-central/rev/39cb1e96cf97713c444c5a0404d4f84627aee85d/netwerk/cache2/CacheIOThread.cpp#528 https://searchfox.org/mozilla-central/rev/39cb1e96cf97713c444c5a0404d4f84627aee85d/netwerk/base/nsSocketTransportService2.cpp#579
Would be good to get a profiler label with the IDLE category into these stacks as well, so that the thread category graph in the profiler will correctly show these threads as idle.
Attachment #9022406 - Attachment description: Bug 1504347 - Add AUTO_PROFILER_THREAD_SLEEP around Necko waits - r?mayhemer → Bug 1504347 - Add IDLE markers and AUTO_PROFILER_THREAD_SLEEP around Necko waits - r?mayhemer
Thanks for the suggestion Markus.
Pushed by email@example.com: https://hg.mozilla.org/integration/autoland/rev/15adeb85dc27 Add IDLE markers and AUTO_PROFILER_THREAD_SLEEP around Necko waits - r=mayhemer
You need to log in before you can comment on or make changes to this bug.