Closed
Bug 1504347
Opened 6 years ago
Closed 6 years ago
Missing AUTO_PROFILER_THREAD_SLEEPs in Necko prevent duplication of profiler samples when thread is asleep
Categories
(Core :: Gecko Profiler, enhancement)
Core
Gecko Profiler
Tracking
()
RESOLVED
FIXED
mozilla65
| Tracking | Status | |
|---|---|---|
| firefox65 | --- | fixed |
People
(Reporter: mozbugz, Assigned: mozbugz)
References
Details
Attachments
(1 file)
As suggested by :mayhemer in https://phabricator.services.mozilla.com/D10671#256902
Could we mark few more places in necko?
https://searchfox.org/mozilla-central/rev/39cb1e96cf97713c444c5a0404d4f84627aee85d/netwerk/cache2/CacheIOThread.cpp#528
https://searchfox.org/mozilla-central/rev/39cb1e96cf97713c444c5a0404d4f84627aee85d/netwerk/base/nsSocketTransportService2.cpp#579
|
Assignee | |
Comment 1•6 years ago
|
||
|
||
Comment 2•6 years ago
|
||
Would be good to get a profiler label with the IDLE category into these stacks as well, so that the thread category graph in the profiler will correctly show these threads as idle.
|
||
Updated•6 years ago
|
Attachment #9022406 -
Attachment description: Bug 1504347 - Add AUTO_PROFILER_THREAD_SLEEP around Necko waits - r?mayhemer → Bug 1504347 - Add IDLE markers and AUTO_PROFILER_THREAD_SLEEP around Necko waits - r?mayhemer
|
|
Assignee | |
Comment 3•6 years ago
|
||
Thanks for the suggestion Markus.
Pushed by gsquelart@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/15adeb85dc27
Add IDLE markers and AUTO_PROFILER_THREAD_SLEEP around Necko waits - r=mayhemer
|
||
Comment 5•6 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla65
You need to log in
before you can comment on or make changes to this bug.
Description
•