1503491 - Remove RemoteSpellcheckEngine.Check sync IPC if possible

Status: RESOLVED FIXED

(Core :: Spelling checker, enhancement)

Description

[Makoto Kato [:m_kato]]

When inputting text to <textarea>, it spends a lot of time for sellchecker to wait Chrome process

https://perf-html.io/public/2d42609a638db796e65530e1f3d53bfde8e7c21f/calltree/?globalTrackOrder=0-1-2-3&hiddenGlobalTracks=1-2&localTrackOrderByPid=746-0~&thread=3&v=3

If we can replace RemoteSpellcheckEngine.Check with async IPC, it will improve performance.

Comment 1

[Mayank Bansal]

dupe of bug 1340573 or bug 1303749 ?

Comment 2

[Makoto Kato [:m_kato]]

No one uses CheckCurrentWordNoSuggest. So let's remove this IPC!

Comment 3

[Makoto Kato [:m_kato]]

Attachment: Bug 1503491 - Part 1. Remove CheckCurrentWordNoSuggest. r?masayuki

No one uses CheckCurrentWordNoSuggest. So I would like to get a rid of this
method. And this method is only user of mozSpellChecker::CheckWord. So
mozSpellChecker::CheckWord shouldn't allow that aSuggestions is nullptr on
content process since we already have async API as mozSpellChecker::CheckWords.

Comment 4

[Makoto Kato [:m_kato]]

Attachment: Bug 1503491 - Part 2. Remove PRemoteSpellcheckEngine::Check. r?mccr8,masayuki

Let's going away due to unused.

Depends on D19303

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/cd123a9e88f7
Part 1. Remove CheckCurrentWordNoSuggest. r=masayuki
https://hg.mozilla.org/integration/autoland/rev/08b2938c0ea8
Part 2. Remove PRemoteSpellcheckEngine::Check. r=mccr8,masayuki

Comment 6

[Oana Pop-Rus]

https://hg.mozilla.org/mozilla-central/rev/cd123a9e88f7
https://hg.mozilla.org/mozilla-central/rev/08b2938c0ea8