Closed
Bug 1503536
Opened 6 years ago
Closed 6 years ago
Call ApplySettings in MediaEngineWebRTCMicrophoneSource::Start
Categories
(Core :: WebRTC: Audio/Video, defect, P2)
Tracking
()
RESOLVED
FIXED
mozilla65
Tracking | Status | |
---|---|---|
firefox-esr60 | --- | unaffected |
firefox63 | --- | unaffected |
firefox64 | + | fixed |
firefox65 | + | fixed |
People
(Reporter: padenot, Assigned: padenot)
References
Details
(Keywords: regression)
Attachments
(2 files)
47 bytes,
text/x-phabricator-request
|
jcristau
:
approval-mozilla-beta+
|
Details | Review |
3.69 KB,
patch
|
Details | Diff | Splinter Review |
Otherwise, some bits of processing won't be enabled/disabled correctly.
This was regressed by bug 1487057.
Assignee | ||
Comment 1•6 years ago
|
||
Assignee | ||
Updated•6 years ago
|
Assignee: nobody → padenot
Priority: -- → P2
Assignee | ||
Comment 2•6 years ago
|
||
We want this uplifted to 64, this will apply just fine.
Assignee | ||
Comment 3•6 years ago
|
||
Pushed by padenot@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/cdfaa36dcd55
Call ApplySettings in MediaEngineWebRTCMicrophoneSource::Start. r=pehrsons
Comment 5•6 years ago
|
||
bugherder |
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla65
Comment 6•6 years ago
|
||
[Tracking Requested - why for this release]: Nasty echo feedback in WebRTC calls; intolerable noise in local loop WebRTC demos.
Regression range points confirms bug 1487057:
12:12.64 INFO: Last good revision: 9268ec81fb01ae1fd1162fc6866ef8f74cd3ea09
12:12.64 INFO: First bad revision: 0190c5793ffeeb0eec281cf377435c7a592415f3
12:12.65 INFO: Pushlog:
https://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=9268ec81fb01ae1fd1162fc6866ef8f74cd3ea09&tochange=0190c5793ffeeb0eec281cf377435c7a592415f3
status-firefox63:
--- → unaffected
status-firefox64:
--- → affected
status-firefox-esr60:
--- → unaffected
status-geckoview62:
--- → unaffected
status-geckoview63:
--- → unaffected
tracking-firefox64:
--- → ?
Backout by rgurzau@mozilla.com:
https://hg.mozilla.org/mozilla-central/rev/53647b724d3b
Backed out changeset cdfaa36dcd55 for perma assertion failure at media/webrtc/MediaEngineWebRTCAudio.cpp a=backout
Comment 8•6 years ago
|
||
Backed out changeset cdfaa36dcd55 (bug 1503536) for perma assertion failure at media/webrtc/MediaEngineWebRTCAudio.cpp a=backout
Backout link: https://hg.mozilla.org/mozilla-central/rev/53647b724d3bbc77055bd9167fa125c5d52e4eda
Push with failures: https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&resultStatus=pending%2Crunning%2Csuccess%2Ctestfailed%2Cbusted%2Cexception&group_state=expanded&searchStr=mochitest%2Cmedia%2Cdebug&platform=linux&job_type_symbol=mda3&selectedJob=209856624&revision=4115e3cf7ad0054a3846926eb7b85afb019ff385
Log link: https://treeherder.mozilla.org/logviewer.html#?job_id=209856624&repo=mozilla-inbound&lineNumber=9719
Log snippet: [task 2018-11-05T16:58:11.324Z] 16:58:11 INFO - GECKO(1065) | Assertion failure: aStream->GraphImpl()->IterationEnd() > mLastCallbackAppendTime, at /builds/worker/workspace/build/src/dom/media/webrtc/MediaEngineWebRTCAudio.cpp:1024
[task 2018-11-05T16:59:34.769Z] 16:59:34 INFO - GECKO(1065) | #01: mozilla::MediaDevice::Pull(RefPtr<mozilla::SourceMediaStream> const&, int, long, nsMainThreadPtrHandle<nsIPrincipal> const&) [mfbt/RefPtr.h:84]
[task 2018-11-05T16:59:34.770Z] 16:59:34 INFO -
[task 2018-11-05T16:59:34.771Z] 16:59:34 INFO - GECKO(1065) | #02: mozilla::SourceListener::NotifyPull(mozilla::MediaStreamGraph*, long) [mfbt/UniquePtr.h:324]
[task 2018-11-05T16:59:34.771Z] 16:59:34 INFO -
[task 2018-11-05T16:59:34.772Z] 16:59:34 INFO - GECKO(1065) | #03: mozilla::SourceMediaStream::PullNewData(long) [xpcom/threads/Mutex.h:250]
[task 2018-11-05T16:59:34.773Z] 16:59:34 INFO -
[task 2018-11-05T16:59:34.774Z] 16:59:34 INFO - GECKO(1065) | #04: mozilla::MediaStreamGraphImpl::UpdateGraph(long) [dom/media/MediaStreamGraph.cpp:1282]
[task 2018-11-05T16:59:34.775Z] 16:59:34 INFO -
[task 2018-11-05T16:59:34.776Z] 16:59:34 INFO - GECKO(1065) | #05: mozilla::MediaStreamGraphImpl::OneIteration(long) [dom/media/MediaStreamGraph.cpp:1475]
[task 2018-11-05T16:59:34.777Z] 16:59:34 INFO -
[task 2018-11-05T16:59:34.778Z] 16:59:34 INFO - GECKO(1065) | #06: mozilla::AudioCallbackDriver::DataCallback(float const*, float*, long) [dom/media/GraphDriver.cpp:1008]
[task 2018-11-05T16:59:34.779Z] 16:59:34 INFO -
[task 2018-11-05T16:59:34.781Z] 16:59:34 INFO - GECKO(1065) | #07: <futures::future::lazy::Lazy<F, R> as futures::future::Future>::poll [media/audioipc/client/src/stream.rs:110]
[task 2018-11-05T16:59:34.783Z] 16:59:34 INFO -
[task 2018-11-05T16:59:34.785Z] 16:59:34 INFO - GECKO(1065) | #08: std::panicking::try::do_call [third_party/rust/futures/src/future/catch_unwind.rs:32]
[task 2018-11-05T16:59:34.787Z] 16:59:34 INFO -
[task 2018-11-05T16:59:34.791Z] 16:59:34 INFO - GECKO(1065) | #09: __rust_maybe_catch_panic [/rustc/da5f414c2c0bfe5198934493f04c676e2b23ff2e/src/libpanic_abort/lib.rs:43]
Flags: needinfo?(padenot)
Updated•6 years ago
|
Status: RESOLVED → REOPENED
status-firefox65:
fixed → ---
Resolution: FIXED → ---
Target Milestone: mozilla65 → ---
Updated•6 years ago
|
Updated•6 years ago
|
status-geckoview62:
unaffected → ---
status-geckoview63:
unaffected → ---
Pushed by paul@paul.cx:
https://hg.mozilla.org/integration/mozilla-inbound/rev/eae4fa2210f5
Call ApplySettings in MediaEngineWebRTCMicrophoneSource::Start. r=pehrsons
Comment 10•6 years ago
|
||
bugherder |
Status: REOPENED → RESOLVED
Closed: 6 years ago → 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla65
Assignee | ||
Updated•6 years ago
|
Flags: needinfo?(padenot)
Comment 11•6 years ago
|
||
Please nominate this for Beta uplift when you're comfortable doing so.
tracking-firefox65:
--- → +
Flags: needinfo?(padenot)
Assignee | ||
Comment 13•6 years ago
|
||
Comment on attachment 9021474 [details]
Bug 1503536 - Call ApplySettings in MediaEngineWebRTCMicrophoneSource::Start. r?pehrsons
[Beta/Release Uplift Approval Request]
Feature/Bug causing the regression: Bug 1487057
User impact if declined: No Echo Cancelation on webrtc calls
Is this code covered by automated tests?: No
Has the fix been verified in Nightly?: Yes
Needs manual test from QE?: No
If yes, steps to reproduce:
List of other uplifts needed: None
Risk to taking this patch: Low
Why is the change risky/not risky? (and alternatives if risky): The code is simple, we're just calling a method that we forgot to call.
String changes made/needed: none
Flags: needinfo?(padenot)
Attachment #9021474 -
Flags: approval-mozilla-beta?
Comment 14•6 years ago
|
||
Comment on attachment 9021474 [details]
Bug 1503536 - Call ApplySettings in MediaEngineWebRTCMicrophoneSource::Start. r?pehrsons
webrtc regression fix, spent a week in nightly; approved for 64.0b10
Attachment #9021474 -
Flags: approval-mozilla-beta? → approval-mozilla-beta+
Assignee | ||
Comment 15•6 years ago
|
||
I'll be providing a patch in a second.
Assignee | ||
Comment 16•6 years ago
|
||
This is the correct beta patch.
It effectively backs bug 1499426 out from beta, that was uplifted earlier, and adds the fix for this bug.
Comment 17•6 years ago
|
||
bugherder uplift |
Updated•6 years ago
|
Flags: qe-verify-
You need to log in
before you can comment on or make changes to this bug.
Description
•