Closed
Bug 1503726
Opened 6 years ago
Closed 6 years ago
Null check release callback in CGDataProviderCreateWithData redirection
Categories
(Core Graveyard :: Web Replay, enhancement)
Core Graveyard
Web Replay
Tracking
(firefox65 fixed)
RESOLVED
FIXED
mozilla65
| Tracking | Status | |
|---|---|---|
| firefox65 | --- | fixed |
People
(Reporter: bhackett1024, Assigned: bhackett1024)
References
Details
Attachments
(1 file)
|
995 bytes,
patch
|
mccr8
:
review+
|
Details | Diff | Splinter Review |
CGDataProviderCreateWithData takes a callback to release the data it is passed, which we invoke directly sometimes when replaying. This callback is optional and needs to be null checked; because of this, web replay pretty much broke completely after bug 1502152, which pulled in a new Skia version with new calls to CGDataProviderCreateWithData that crash here. I don't know why this didn't get caught in automated tests.
Attachment #9021689 -
Flags: review?(continuation)
|
||
Updated•6 years ago
|
Attachment #9021689 -
Flags: review?(continuation) → review+
Pushed by bhackett@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/0473f86823f2
Null check release callback in CGDataProviderCreateWithData redirection, r=mccr8.
|
||
Comment 2•6 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox65:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla65
|
||
Updated•5 years ago
|
Product: Core → Core Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•