1503805 - 359.98 - 459.8% compiler_metrics num_static_constructors (windows2012-32, windows2012-64) regression on push 0c7b395eedb4b03e90bd2b0ac909582f37f77677 (Wed Oct 24 2018)

Status: RESOLVED INVALID

(Testing :: General, defect)

Description

[Ionuț Goldan [:igoldan]]

We have detected a build metrics regression from push:

https://hg.mozilla.org/releases/mozilla-beta/pushloghtml?changeset=0c7b395eedb4b03e90bd2b0ac909582f37f77677

As author of one of the patches included in that push, we need your help to address this regression.

Regressions:

460%  compiler_metrics num_static_constructors windows2012-64 opt msvc     101.29 -> 567.00
360%  compiler_metrics num_static_constructors windows2012-32 opt msvc     101.31 -> 466.00


You can find links to graphs and comparison views for each of the above tests at: https://treeherder.mozilla.org/perf.html#/alerts?id=17195

On the page above you can see an alert for each affected platform as well as a link to a graph showing the history of scores for this test. There is also a link to a treeherder page showing the jobs in a pushlog format.

To learn more about the regressing test(s), please see: https://developer.mozilla.org/en-US/docs/Mozilla/Performance/Automated_Performance_Testing_and_Sheriffing/Build_Metrics

Comment 1

[Ionuț Goldan [:igoldan]]

I tried bisecting this on Try, but didn't manage to find the culprit. So, please state which of the following bugs is more related to these regressions?

bug 1498710
bug 1374790
bug 1499996
bug 1500475
bug 1497860
bug 1497575
bug 1459891

Comment 2

[Kartikaya Gupta (email:[e-mail])]

None of those pushes touches any C++ files so my guess is that Tom's taskcluster changes didn't go quite right and changed compiler options or something.

Comment 3

[Simon Fraser [:sfraser] ⌚️GMT]

I think the public suffix list one (bug 1459891) it one of the least likely on the list, so am clearing needinfo from me

Comment 4

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

I just added a line into a mochitest so that must not be caused by bug1499996.

Comment 5

[Dave Townsend [:mossop]]

Mine was just an xpcshell test change, no C++.

Comment 6

[Tom Prince [:tomprince]]

This is an expected change. The msvc builds on beta were not using the correct mozconfig, so were being compiled with clang instead. The metrics here are in line with the msvc metrics on mozilla-central.