Status

enhancement
RESOLVED FIXED
8 months ago
8 months ago

People

(Reporter: jorgk, Assigned: jorgk)

Tracking

Trunk

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments, 1 obsolete attachment)

Assignee

Description

8 months ago
Looks like we need to do this:

-#include "nsWeakReference.h"
-#include "nsWeakPtr.h"
+#include "nsIWeakReferenceUtils.h"
Assignee

Comment 1

8 months ago
Posted patch 1503839-weak.patch (obsolete) — Splinter Review
This compiles so far.
Assignee: nobody → jorgk
Status: NEW → ASSIGNED
Assignee

Comment 2

8 months ago
Removed a few necessary includes. Aceman can tell us whether more could have been removed.
Attachment #9021788 - Attachment is obsolete: true
Attachment #9021796 - Flags: review?(acelists)

Comment 3

8 months ago
Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/de28835aa5f1
Port bug 1503207: replace include of nsWeakPtr.h with nsIWeakReferenceUtils.h, use nsWeakPtr. rs=bustage-fix
Status: ASSIGNED → RESOLVED
Closed: 8 months ago
Resolution: --- → FIXED

Updated

8 months ago
Attachment #9021796 - Flags: review?(acelists) → review+

Comment 4

8 months ago
Found some more possible clean up.
Attachment #9021955 - Flags: review?(jorgk)
Assignee

Comment 5

8 months ago
Comment on attachment 9021955 [details] [diff] [review]
1503839.patch weak2

Review of attachment 9021955 [details] [diff] [review]:
-----------------------------------------------------------------

I can do the adjustment before landing.

::: ldap/xpcom/public/nsILDAPMessageListener.idl
@@ +13,1 @@
>   * A callback interface to be implemented by any objects that want to 

Let's lose this hunk. We can take care of white-space in another bug.

::: mailnews/addrbook/src/nsAbLDAPDirectoryQuery.h
@@ +9,5 @@
>  #include "nsIAbDirectoryQuery.h"
>  #include "nsILDAPConnection.h"
>  #include "nsILDAPMessageListener.h"
>  #include "nsILDAPURL.h"
> +#include "nsWeakReference.h" // this is needed, but why?

Let's lose this comment, or research it and document it.
Attachment #9021955 - Flags: review?(jorgk) → review+

Comment 6

8 months ago
I did research it, but don't know why it is needed. The compiler claims the nsILDAPCOnnection class in incomplete. But I do not see why, it does not have any weak references that are obviously seen.
So I add the comment so that somebody may be more successful in researching it further. But you can drop it if you want.

Comment 7

8 months ago
Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/3cb2a9dc80d3
clean up some more ns*WeakReference*.h includes. r=jorgk
You need to log in before you can comment on or make changes to this bug.