currently using protocol_handlers will always prompt asking the user to select a handler, which is completely unhelpful since the ui is so bad. We should - set the default handler if no existing handler is installed - force the prompt if an existing handler exists so the user can choose (otherwise finding this is difficult)
Assignee: nobody → mixedpuppy
If no handlers exist for a protocol, dont show the handler chooser dialog. If a default handler exists, force showing the dialog when a new handler has been installed so the user may choose the new handler.
Attachment #9021941 - Attachment is obsolete: true
Pushed by email@example.com: https://hg.mozilla.org/integration/autoland/rev/0a69cd7ad7ac correctly show/not show protocol hander dialog, r=aswan
Status: NEW → RESOLVED
Last Resolved: 5 months ago
status-firefox65: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla65
Will manual testing be required on this bug?
I may be worth a bit of manual testing. here are two that can be done after installing this extension. str 1; test protocol does not show dialog - open a tab and enter the url ext+test:foobar - tab show open to extension page, no dialog str 2; test protocol does show dialog - open a tab and enter mail:foobar - dialog should open asking how to handle it - extension should be listed in the choices - selecting extension should result in page opening If you make a copy of the extension, changing the id and name in the manifest, and have both installed: str 3; test protocol now shows dialog - open a tab and enter the url ext+test:foobar - dialog should open asking how to handle it - two extensions should be listed in the choices - selecting an extension should result in page opening
Thank you for the test extension Shane. All scenarios work as expected and listed in the above comment, however I had to use 'mailto:foobar' on str2 instead. Verified using 65.0a1 on Windows 10 x64 bit.
Status: RESOLVED → VERIFIED
status-firefox65: fixed → verified
(In reply to Vlad Jiman from comment #9) > had to use 'mailto:foobar' on str2 instead. Oops, sorry, mailto is correct.
You need to log in before you can comment on or make changes to this bug.