1504008 - bypass protocol handler prompt when unecessary

Status: VERIFIED FIXED

(WebExtensions :: General, enhancement, P1)

Description

[Shane Caraveo (:mixedpuppy)]

currently using protocol_handlers will always prompt asking the user to select a handler, which is completely unhelpful since the ui is so bad.  

We should
- set the default handler if no existing handler is installed
- force the prompt if an existing handler exists so the user can choose (otherwise finding this is difficult)

Comment 1

[Shane Caraveo (:mixedpuppy)]

Attachment: protocolDialog

Comment 2

[Shane Caraveo (:mixedpuppy)]

Attachment: Bug 1504008 correctly show/not show protocol hander dialog, r?aswan

If no handlers exist for a protocol, dont show the handler chooser dialog.
If a default handler exists, force showing the dialog when a new handler
has been installed so the user may choose the new handler.

Comment 4

[Shane Caraveo (:mixedpuppy)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=81d794383c52208aa8ab3e09992e841fb78ccfbe

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0a69cd7ad7ac
correctly show/not show protocol hander dialog, r=aswan

Comment 6

[Stefan Hindli [:stefan_hindli]]

https://hg.mozilla.org/mozilla-central/rev/0a69cd7ad7ac

Comment 7

[Vlad Jiman]

Will manual testing be required on this bug?

Comment 8

[Shane Caraveo (:mixedpuppy)]

Attachment: test-protocol.xpi

I may be worth a bit of manual testing.  here are two that can be done after installing this extension.

str 1; test protocol does not show dialog

- open a tab and enter the url ext+test:foobar
- tab show open to extension page, no dialog

str 2; test protocol does show dialog

- open a tab and enter mail:foobar
- dialog should open asking how to handle it
- extension should be listed in the choices
- selecting extension should result in page opening

If you make a copy of the extension, changing the id and name in the manifest, and have both installed:

str 3; test protocol now shows dialog

- open a tab and enter the url ext+test:foobar
- dialog should open asking how to handle it
- two extensions should be listed in the choices
- selecting an extension should result in page opening

Comment 9

[Vlad Jiman]

Thank you for the test extension Shane.

All scenarios work as expected and listed in the above comment, however I had to use 'mailto:foobar' on str2 instead. Verified using 65.0a1 on Windows 10 x64 bit.

Comment 10

[Shane Caraveo (:mixedpuppy)]

(In reply to Vlad Jiman from comment #9)

> had to use 'mailto:foobar' on str2 instead.

Oops, sorry, mailto is correct.