Closed Bug 1504078 Opened 7 years ago Closed 7 years ago

Use references in the shapes code.

Categories

(Core :: Layout, enhancement, P3)

Product:
Core
Component:
Layout
Type:
enhancement

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla65
Tracking Flags:
Tracking Status
firefox65 --- fixed

People

(Reporter: emilio, Assigned: emilio)

Details

Attachments

(1 file)

Bug 1504078 - Use references in the shapes code.
47 bytes, text/x-phabricator-request
Details | Review
I think it's nicer, I had to look at which ones were nullable and which ones weren't a bit while working on bug 1500575 & related bugs.
Assignee: nobody → emilio
Priority: -- → P3
It doesn't make much sense to return const UniquePtr<Foo>& for something that can't be null, it's just confusing. Also make more stuff actually const.
Pushed by emilio@crisal.io: https://hg.mozilla.org/integration/autoland/rev/d34c32dab9c9 Use references in the shapes code. r=bradwerth,TYLin
https://hg.mozilla.org/mozilla-central/rev/d34c32dab9c9
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox65: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla65
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: