Closed Bug 1504188 Opened Last year Closed Last year

Can't build on Mac with sandbox disabled

Categories

(Core :: Security: Process Sandboxing, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla65
Tracking Status
firefox65 --- fixed

People

(Reporter: marco, Assigned: marco)

References

(Blocks 1 open bug)

Details

Attachments

(2 files)

[task 2018-11-02T11:41:09.594Z] 11:41:09     INFO -  In file included from /builds/worker/workspace/build/src/obj-firefox/dom/ipc/Unified_cpp_dom_ipc0.cpp:47:
[task 2018-11-02T11:41:09.594Z] 11:41:09     INFO -  /builds/worker/workspace/build/src/dom/ipc/ContentParent.cpp:2175:24: error: no member named 'GetAppPath' in 'nsMacUtilsImpl'
[task 2018-11-02T11:41:09.594Z] 11:41:09     INFO -    if (!nsMacUtilsImpl::GetAppPath(appPath)) {
[task 2018-11-02T11:41:09.594Z] 11:41:09     INFO -         ~~~~~~~~~~~~~~~~^
[task 2018-11-02T11:41:09.594Z] 11:41:09     INFO -  /builds/worker/workspace/build/src/dom/ipc/ContentParent.cpp:2236:23: error: no member named 'GetDirectoryPath' in 'nsMacUtilsImpl'
[task 2018-11-02T11:41:09.596Z] 11:41:09     INFO -        nsMacUtilsImpl::GetDirectoryPath(bloatLog);
[task 2018-11-02T11:41:09.596Z] 11:41:09     INFO -        ~~~~~~~~~~~~~~~~^
[task 2018-11-02T11:41:09.596Z] 11:41:09     INFO -  2 errors generated.
[task 2018-11-02T11:41:09.596Z] 11:41:09     INFO -  /builds/worker/workspace/build/src/config/rules.mk:1135: recipe for target 'Unified_cpp_dom_ipc0.o' failed
Likely a regression from bug 1431441.
Blocks: 1431441
Assignee: nobody → mcastelluccio
Status: NEW → ASSIGNED
Attached patch PatchSplinter Review
Attachment #9022119 - Flags: review?(agaynor)
Attached patch Part 2Splinter Review
Attachment #9022157 - Flags: review?(agaynor)
Thanks for fixing this, Marco. Alex is on PTO right now
Attachment #9022119 - Flags: review?(agaynor) → review+
Attachment #9022157 - Flags: review?(agaynor) → review+
Pushed by mcastelluccio@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/11b22116160c
Don't define AppendSandboxParams if building the sandbox is disabled. r=haik
https://hg.mozilla.org/integration/mozilla-inbound/rev/ab19a1589b29
Don't include Sandbox.h and don't use EarlyStartMacSandboxIfEnabled if the sandbox is disabled. r=haik
https://hg.mozilla.org/mozilla-central/rev/11b22116160c
https://hg.mozilla.org/mozilla-central/rev/ab19a1589b29
Status: ASSIGNED → RESOLVED
Closed: Last year
Resolution: --- → FIXED
Target Milestone: --- → mozilla65
You need to log in before you can comment on or make changes to this bug.