1504188 - Can't build on Mac with sandbox disabled

Status: RESOLVED FIXED

(Core :: Security: Process Sandboxing, defect)

Description

[Marco Castelluccio [:marco]]

[task 2018-11-02T11:41:09.594Z] 11:41:09     INFO -  In file included from /builds/worker/workspace/build/src/obj-firefox/dom/ipc/Unified_cpp_dom_ipc0.cpp:47:
[task 2018-11-02T11:41:09.594Z] 11:41:09     INFO -  /builds/worker/workspace/build/src/dom/ipc/ContentParent.cpp:2175:24: error: no member named 'GetAppPath' in 'nsMacUtilsImpl'
[task 2018-11-02T11:41:09.594Z] 11:41:09     INFO -    if (!nsMacUtilsImpl::GetAppPath(appPath)) {
[task 2018-11-02T11:41:09.594Z] 11:41:09     INFO -         ~~~~~~~~~~~~~~~~^
[task 2018-11-02T11:41:09.594Z] 11:41:09     INFO -  /builds/worker/workspace/build/src/dom/ipc/ContentParent.cpp:2236:23: error: no member named 'GetDirectoryPath' in 'nsMacUtilsImpl'
[task 2018-11-02T11:41:09.596Z] 11:41:09     INFO -        nsMacUtilsImpl::GetDirectoryPath(bloatLog);
[task 2018-11-02T11:41:09.596Z] 11:41:09     INFO -        ~~~~~~~~~~~~~~~~^
[task 2018-11-02T11:41:09.596Z] 11:41:09     INFO -  2 errors generated.
[task 2018-11-02T11:41:09.596Z] 11:41:09     INFO -  /builds/worker/workspace/build/src/config/rules.mk:1135: recipe for target 'Unified_cpp_dom_ipc0.o' failed

Comment 1

[Marco Castelluccio [:marco]]

Likely a regression from bug 1431441.

Comment 2

[Marco Castelluccio [:marco]]

Attachment: Patch

Comment 3

[Marco Castelluccio [:marco]]

Attachment: Part 2

Comment 4

[Haik Aftandilian [:haik]]

Thanks for fixing this, Marco. Alex is on PTO right now

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/11b22116160c
Don't define AppendSandboxParams if building the sandbox is disabled. r=haik
https://hg.mozilla.org/integration/mozilla-inbound/rev/ab19a1589b29
Don't include Sandbox.h and don't use EarlyStartMacSandboxIfEnabled if the sandbox is disabled. r=haik

Comment 6

[Stefan Hindli [:stefan_hindli]]

https://hg.mozilla.org/mozilla-central/rev/11b22116160c
https://hg.mozilla.org/mozilla-central/rev/ab19a1589b29