1504214 - The old live bookmarks icons are still displayed after their removal (conversion)

Status: RESOLVED WONTFIX

(Firefox Graveyard :: RSS Discovery and Preview, defect)

Description

[Iulia Cristescu, QA [:JuliaC] (away, please needinfo? [e-mail])]

[Affected versions]:
- 64.0b6 build1 (20181101155334)

[Affected platforms]:
- Windows 10 x64
- Ubuntu 16 x64
- mac OS 10.13.6

[Steps to reproduce]:
1. Launch an old version of Firefox (63 or earlier) using a clean profile
2. Navigate to the Bookmarks menu and enable the Bookmarks Toolbar
3. Add several live bookmarks (using sites with live feeds e.g. https://kotaku.com/, https://abcnews.go.com/, https://blog.hubspot.com/marketing, https://www.foxnews.com/)
4. Close the browser
5. Open a recent version of Firefox (64 or later) 
- inspect the Bookmarks toolbar 

[Expected result]:
- the live bookmarks previously available have been converted to normal bookmarks on the Bookmarks toolbar

[Actual result]:
- there are a few seconds when the old live bookmarks icons are still displayed on the Bookmarks toolbar - see the following screencast https://drive.google.com/file/d/1ngNGgFiUijilPrp7y1udEoy2So5ZYfEw/view?usp=sharing

[Regression range]:
- This is not a recent regression, since it's reproducible all the way back to Devedition 64.0b1 (20181015220336)

Comment 1

[:Gijs (he/him)]

I think this is an unavoidable consequence of running the migration async.

If we wanted to, we could display: none items that were live bookmarks, which would be a relatively safe way of avoiding them being visible, but it feels hacky. Marco, what do you think?

Comment 2

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

I think it's working as expected and adding complication wouldn't balance the benefit.
Surely it looks particularly prominent in this video, but the percentage of users having lots of livemarks directly visible from the toolbar must be low (because we know very few users have livemarks in general), and this is a one-time flicker. Whatever thing we do would cause some sort of flicker in this case, even if we'd:
* hide and then show again the toolbar
* hide livermarks and then add bookmarks

To sum up, while the problem exists, the solution is unclear and more expensive than the actual annoyance.