Closed
Bug 1504478
Opened 5 years ago
Closed 5 years ago
Remove deprecated Marionette commands
Categories
(Remote Protocol :: Marionette, enhancement, P1)
Remote Protocol
Marionette
Tracking
(firefox64 fixed, firefox65 fixed)
RESOLVED
FIXED
mozilla65
People
(Reporter: ato, Assigned: ato)
References
Details
Attachments
(3 files, 3 obsolete files)
Following a big naming scheme change, there are a lot of Marionette commands we can remove since Firefox 63.
Assignee | ||
Updated•5 years ago
|
Assignee: nobody → ato
Status: NEW → ASSIGNED
Assignee | ||
Comment 1•5 years ago
|
||
This removes a series of deprecated Marionette commands following a big naming scheme change a while back. These commands could have safely been removed since Firefox 63.
Assignee | ||
Comment 2•5 years ago
|
||
singelTap is still in use in the Marionette Python client and we therefore have to wait a bit before it can be removed from the Marionette server.
Assignee | ||
Comment 3•5 years ago
|
||
Depends on D10827
Assignee | ||
Comment 4•5 years ago
|
||
The singleTap and acceptConnections commands are deprecated in favour of, respectively, Marionette:SingleTap and Marionette:AcceptConnections.
Assignee | ||
Comment 5•5 years ago
|
||
Depends on D10835
Assignee | ||
Comment 6•5 years ago
|
||
This removes a series of deprecated Marionette commands following a big naming scheme change a while back. These commands could have safely been removed since Firefox 63. singleTap and acceptConnections were still in use in the Marionette Python client, so they can only be removed in Firefox 66 at the earliest. WebDriver:AcceptDialog is used by geckodriver, which means it would have to drop support for Firefox 57 in order to change to use WebDriver:AcceptAlert. Marking this as deprecated, but used in geckodriver for now. Depends on D10836
Updated•5 years ago
|
Attachment #9022411 -
Attachment is obsolete: true
Updated•5 years ago
|
Attachment #9022423 -
Attachment is obsolete: true
Updated•5 years ago
|
Attachment #9022422 -
Attachment is obsolete: true
Pushed by atolfsen@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/341265ae91c1 marionette: use SingleTap and AcceptConnections in Python client; r=whimboo https://hg.mozilla.org/integration/autoland/rev/bfce81a6090e marionette: update tests to use non-deprecated commands; r=whimboo https://hg.mozilla.org/integration/autoland/rev/a1fcca885ad4 marionette: remove deprecated commands; r=whimboo
Comment 8•5 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/341265ae91c1 https://hg.mozilla.org/mozilla-central/rev/bfce81a6090e https://hg.mozilla.org/mozilla-central/rev/a1fcca885ad4
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
status-firefox65:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla65
Comment 9•5 years ago
|
||
(In reply to Raul Gurzau (:RaulGurzau) from comment #8) > https://hg.mozilla.org/mozilla-central/rev/341265ae91c1 Please uplift this test-only change to mozilla-beta to fix a regression as introduced by bug 1433873. The other commits don't have to be uplifted! Thanks.
Whiteboard: [checkin-needed-beta][1st patch only]
Comment 10•5 years ago
|
||
bugherder uplift |
https://hg.mozilla.org/releases/mozilla-beta/rev/f81a913aa2dc
status-firefox64:
--- → fixed
Whiteboard: [checkin-needed-beta][1st patch only]
Comment 11•5 years ago
|
||
bugherder uplift |
https://hg.mozilla.org/releases/mozilla-beta/rev/acff7819c694
Updated•5 years ago
|
Priority: -- → P1
Updated•8 months ago
|
Product: Testing → Remote Protocol
You need to log in
before you can comment on or make changes to this bug.
Description
•