1504478 - Remove deprecated Marionette commands

Status: RESOLVED FIXED

(Remote Protocol :: Marionette, enhancement, P1)

Description

[Andreas Tolfsen ❲:ato❳]

Following a big naming scheme change, there are a lot of Marionette
commands we can remove since Firefox 63.

Comment 1

[Andreas Tolfsen ❲:ato❳]

Attachment: bug 1504478: marionette: remove deprecated commands

This removes a series of deprecated Marionette commands following
a big naming scheme change a while back.  These commands could have
safely been removed since Firefox 63.

Comment 2

[Andreas Tolfsen ❲:ato❳]

Attachment: bug 1504478: marionette: mark singleTap command as deprecated;

singelTap is still in use in the Marionette Python client and we
therefore have to wait a bit before it can be removed from the
Marionette server.

Comment 3

[Andreas Tolfsen ❲:ato❳]

Attachment: bug 1504478: marionette: update tests to use non-deprecated commands;

Depends on D10827

Comment 4

[Andreas Tolfsen ❲:ato❳]

Attachment: bug 1504478: marionette: use SingleTap and AcceptConnections in Python client;

The singleTap and acceptConnections commands are deprecated in
favour of, respectively, Marionette:SingleTap and
Marionette:AcceptConnections.

Comment 5

[Andreas Tolfsen ❲:ato❳]

Attachment: bug 1504478: marionette: update tests to use non-deprecated commands;

Depends on D10835

Comment 6

[Andreas Tolfsen ❲:ato❳]

Attachment: bug 1504478: marionette: remove deprecated commands;

This removes a series of deprecated Marionette commands following
a big naming scheme change a while back.  These commands could have
safely been removed since Firefox 63.

singleTap and acceptConnections were still in use in the Marionette
Python client, so they can only be removed in Firefox 66 at the
earliest.

WebDriver:AcceptDialog is used by geckodriver, which means it would
have to drop support for Firefox 57 in order to change to use
WebDriver:AcceptAlert.  Marking this as deprecated, but used in
geckodriver for now.

Depends on D10836

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/341265ae91c1
marionette: use SingleTap and AcceptConnections in Python client; r=whimboo
https://hg.mozilla.org/integration/autoland/rev/bfce81a6090e
marionette: update tests to use non-deprecated commands; r=whimboo
https://hg.mozilla.org/integration/autoland/rev/a1fcca885ad4
marionette: remove deprecated commands; r=whimboo

Comment 8

[Raul Gurzau (:RaulG)]

https://hg.mozilla.org/mozilla-central/rev/341265ae91c1
https://hg.mozilla.org/mozilla-central/rev/bfce81a6090e
https://hg.mozilla.org/mozilla-central/rev/a1fcca885ad4

Comment 9

[Henrik Skupin [:whimboo][⌚️UTC+2]]

(In reply to Raul Gurzau (:RaulGurzau) from comment #8)
> https://hg.mozilla.org/mozilla-central/rev/341265ae91c1

Please uplift this test-only change to mozilla-beta to fix a regression as introduced by bug 1433873. The other commits don't have to be uplifted! Thanks.

Comment 10

[Raul Gurzau (:RaulG)]

https://hg.mozilla.org/releases/mozilla-beta/rev/f81a913aa2dc

Comment 11

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/releases/mozilla-beta/rev/acff7819c694