Remove deprecated "acceptConnections" and "singleTap" command end-points.

RESOLVED FIXED in Firefox 64

Status

enhancement
P2
normal
RESOLVED FIXED
7 months ago
7 months ago

People

(Reporter: whimboo, Assigned: whimboo)

Tracking

Trunk
mozilla65
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox64 fixed, firefox65 fixed)

Details

Attachments

(1 attachment, 1 obsolete attachment)

My patch on bug 1433873 introduced a new usage of a deprecated end-point, which shouldn't be used anymore.

We should get this fixed and uplifted, so that the deprecated end-point can be removed.
The patch on bug 1433873 inappropriately used the old end-point for
allowing Marionette to accept new connections again. By updating it
to the new end-point, the old one can completely be removed.
Actually the first patch on this bug is not necessary anymore given that a patch on bug 1504478 already fixed it. I requested the uplift via bug 1504478 comment 9.
Depends on: 1504478
Attachment #9022855 - Attachment is obsolete: true
With uplifting the patch on the other bug, we can also remove "singleTap" right away because it was added for Firefox 60 via bug 1451727.
Summary: Update command end-point "acceptConnections" to "Marionette:AcceptConnections" → Remove deprecated "acceptConnections" and "singleTap" command end-points.
Attachment #9022856 - Attachment description: Bug 1504940 - [marionette] Remove deprecated "acceptConnections" command end-point. r?ato → Bug 1504940 - [marionette] Remove deprecated "acceptConnections" and "singleTap" commands. r?ato

Comment 6

7 months ago
Pushed by hskupin@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/faf94c665ff0
[marionette] Remove deprecated "acceptConnections" and "singleTap" commands. r=ato

Comment 7

7 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/faf94c665ff0
Status: ASSIGNED → RESOLVED
Last Resolved: 7 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla65
Whiteboard: [checkin-needed-beta]
Whiteboard: [checkin-needed-beta]
You need to log in before you can comment on or make changes to this bug.