1504940 - Remove deprecated "acceptConnections" and "singleTap" command end-points.

Status: RESOLVED FIXED

(Remote Protocol :: Marionette, enhancement, P2)

Description

[Henrik Skupin [:whimboo][⌚️UTC+2] (away 02/17 - 02/21)]

My patch on bug 1433873 introduced a new usage of a deprecated end-point, which shouldn't be used anymore.

We should get this fixed and uplifted, so that the deprecated end-point can be removed.

Comment 1

[Henrik Skupin [:whimboo][⌚️UTC+2] (away 02/17 - 02/21)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=768c36208f963ef0a10dcea5e6b39130c958b117

Comment 2

[Henrik Skupin [:whimboo][⌚️UTC+2] (away 02/17 - 02/21)]

Attachment: Bug 1504940 - [marionette] Use "Marionette:AcceptConnections" instead of "acceptConnections". r?ato

The patch on bug 1433873 inappropriately used the old end-point for
allowing Marionette to accept new connections again. By updating it
to the new end-point, the old one can completely be removed.

Comment 3

[Henrik Skupin [:whimboo][⌚️UTC+2] (away 02/17 - 02/21)]

Attachment: Bug 1504940 - [marionette] Remove deprecated "acceptConnections" and "singleTap" commands. r?ato

Depends on D11001

Comment 4

[Henrik Skupin [:whimboo][⌚️UTC+2] (away 02/17 - 02/21)]

Actually the first patch on this bug is not necessary anymore given that a patch on bug 1504478 already fixed it. I requested the uplift via bug 1504478 comment 9.

Comment 5

[Henrik Skupin [:whimboo][⌚️UTC+2] (away 02/17 - 02/21)]

With uplifting the patch on the other bug, we can also remove "singleTap" right away because it was added for Firefox 60 via bug 1451727.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/faf94c665ff0
[marionette] Remove deprecated "acceptConnections" and "singleTap" commands. r=ato

Comment 7

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/faf94c665ff0

Comment 8

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/releases/mozilla-beta/rev/d6cb1ff3b59f