1504492 - Ensure arguments to readableStreamWriteIntoReadRequestCallback are same-compartment

Status: RESOLVED FIXED

(Core :: JavaScript Engine, enhancement, P1)

Description

[Jason Orendorff [:jorendorff]]

Oops:

    auto cb = cx->runtime()->readableStreamWriteIntoReadRequestCallback;
    ...
    // TODO: make this compartment-safe.
    cb(cx, stream, underlyingSource, stream->embeddingFlags(), buffer,
       queueTotalSize, &bytesWritten);

https://searchfox.org/mozilla-central/rev/50ba1dd30cf013bddce1ae756f1b3c95b26f0628/js/src/builtin/Stream.cpp#3715-3717

There's another apparently identical copy of this code, including the comment, here:

https://searchfox.org/mozilla-central/rev/50ba1dd30cf013bddce1ae756f1b3c95b26f0628/js/src/builtin/Stream.cpp#4580-4582

So we might as well common those up while we're here.

Comment 1

[Jason Orendorff [:jorendorff]]

Attachment: Bug 1504492 - Ensure arguments to readableStreamWriteIntoReadRequestCallback are same-compartment. r?tcampbell

Comment 2

[Jason Orendorff [:jorendorff]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=6e492c4f825c95a881f019015c4c15f2125f38e6

Comment 3

[Jason Orendorff [:jorendorff]]

Attachment: Bug 1504492 - Ensure arguments to readableStreamWriteIntoReadRequestCallback are same-compartment. r?tcampbell

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/52e0d4aa9686
Ensure arguments to readableStreamWriteIntoReadRequestCallback are same-compartment. r=tcampbell,baku

Comment 5

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/52e0d4aa9686