1504754 - Debug noscripts version of new tab page fail to load

Status: RESOLVED FIXED

(Firefox :: New Tab Page, enhancement, P2)

Description

[Ed Lee :Mardak]

The debug pages are conditionally packaged for not release/beta:

https://searchfox.org/mozilla-central/rev/7c848ac7630df5baf1314b0c03e015683599efb9/browser/components/newtab/jar.mn#43-46

But we forgot to package the noscripts versions as part of bug 1472212 when it turned on by default.

Comment 1

[Ed Lee :Mardak]

I suppose arguably, it should have been added as part of bug 1416066 when creating those files in the first place.

Comment 2

[GitHub Bugzilla PR Linker]

Attachment: Link to GitHub pull-request: https://github.com/mozilla/activity-stream/pull/4551

Comment 3

[[github robot]]

Commit pushed to master at https://github.com/mozilla/activity-stream

https://github.com/mozilla/activity-stream/commit/afc2c3730892d5a3d477a36c54ad8207a42b1941
Fix Bug 1504754 - Debug noscripts version of new tab page need to be packaged (#4551)

Comment 4

[Ed Lee :Mardak]

The main fix here was reverted in bug 1506205 for test failures

Comment 5

[Ed Lee :Mardak]

The approach here wasn't quite right as indicated by the test failure (why ./mach package didn't fail locally or in our automation is another issue…)

https://treeherder.mozilla.org/logviewer.html#?job_id=210726475&repo=try&lineNumber=43272
[task 2018-11-09T02:54:50.522Z] 02:54:50     INFO -  package> ERROR: The following duplicated files are not allowed:
[task 2018-11-09T02:54:50.522Z] 02:54:50     INFO -  package> browser/chrome/browser/res/activity-stream/prerendered/en-US/activity-stream-noscripts.html
[task 2018-11-09T02:54:50.522Z] 02:54:50     INFO -  package> browser/chrome/browser/res/activity-stream/prerendered/static/activity-stream-debug-noscripts.html
[task 2018-11-09T02:54:50.522Z] 02:54:50     INFO -  package> browser/chrome/browser/res/activity-stream/prerendered/en-US/activity-stream-prerendered-noscripts.html
[task 2018-11-09T02:54:50.522Z] 02:54:50     INFO -  package> browser/chrome/browser/res/activity-stream/prerendered/static/activity-stream-prerendered-debug-noscripts.html

The debug html files would load a different script file however, -noscripts versions don't have script files in html, so they become identical. The fix should be to always load -noscripts ignoring -debug, and make sure the noscripts loader knows to load debug scripts.

Comment 6

[Ed Lee :Mardak]

We don't need to prerender or package a -debug-noscripts html file. For noscripts debug, we already dynamically pick the -dev scripts to inject, and this works with all locales (where before we only bothered packaging "static" english-only version).

Comment 7

[GitHub Bugzilla PR Linker]

Attachment: Link to GitHub pull-request: https://github.com/mozilla/activity-stream/pull/4560

Comment 8

[[github robot]]

Commit pushed to master at https://github.com/mozilla/activity-stream

https://github.com/mozilla/activity-stream/commit/678c6cc941234a6ff1cca513aaf110e47d1fbd6e
Fix Bug 1504754 - Debug noscripts version of new tab page fail to load (#4560)

Comment 9

[Ed Lee :Mardak]

https://hg.mozilla.org/mozilla-central/rev/59ff6b57e94e