1506229 - Duplicate files pass ./mach package locally and on taskcluster but fail on try

Status: RESOLVED FIXED

(Firefox :: New Tab Page, defect, P2)

Description

[Ed Lee :Mardak]

Some reason the original approach for bug 1504754 passed tests:

https://github.com/mozilla/activity-stream/pull/4551

But we noticed try for export bug 1505929 failed to build on all platforms and both debug and opt:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=be7dd4d8657aa4d6df9ae2024dbe778eb30065bd

try: -b do -p win64,linux64,macosx64 -u mochitests,xpcshell -t none --artifact

> package> ERROR: The following duplicated files are not allowed:
> package> Nightly.app/Contents/Resources/browser/chrome/browser/res/activity-stream/prerendered/en-US/activity-stream-noscripts.html
> package> Nightly.app/Contents/Resources/browser/chrome/browser/res/activity-stream/prerendered/static/activity-stream-debug-noscripts.html
> package> Nightly.app/Contents/Resources/browser/chrome/browser/res/activity-stream/prerendered/en-US/activity-stream-prerendered-noscripts.html
> package> Nightly.app/Contents/Resources/browser/chrome/browser/res/activity-stream/prerendered/static/activity-stream-prerendered-debug-noscripts.html
> package> /builds/worker/workspace/build/src/toolkit/mozapps/installer/packager.mk:22: recipe for target 'stage-package' failed
> package> make[5]: *** [stage-package] Error 1
> package> make[5]: Leaving directory '/builds/worker/workspace/build/src/obj-firefox/browser/installer'
> package> /builds/worker/workspace/build/src/toolkit/mozapps/installer/packager.mk:90: recipe for target 'make-package' failed
> package> make[4]: *** [make-package] Error 2
> package> /builds/worker/workspace/build/src/config/rules.mk:431: recipe for target 'default' failed
> package> make[3]: *** [default] Error 2
> package> /builds/worker/workspace/build/src/browser/build.mk:6: recipe for target 'package' failed
> package> make[2]: *** [package] Error 2
> /builds/worker/workspace/build/src/build/moz-automation.mk:84: recipe for target 'automation/package' failed
> make[1]: *** [automation/package] Error 2

Comment 1

[Ed Lee :Mardak]

Aha! I wasn't going totally crazy!! ;) Turns out bug 1418464 added the MOZ_AUTOMATION check to toolkit/mozapps/installer/packager.mk so it doesn't always run find-dupes since about a month ago.

Not sure why bot didn't link https://github.com/mozilla/activity-stream/pull/4562

Comment 2

[[github robot]]

Commit pushed to master at https://github.com/mozilla/activity-stream

https://github.com/mozilla/activity-stream/commit/71d1a89eae916f67e4911cbc317a99b0a9f0f498
Fix Bug 1506229 - Run check for duplicate files in TC (#4562)

Comment 3

[Ed Lee :Mardak]

https://hg.mozilla.org/mozilla-central/rev/e018665be14b