1504819 - Track Changes - Changes are wrongly tracked for disabled properties when selected and browsed through using the Enter key

Status: NEW

(DevTools :: Inspector: Changes, defect, P2)

Description

[Paul_B]

Attachment: disabled property.mp4

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:65.0) Gecko/20100101 Firefox/65.0
Build ID: 20181105100136

[Precondition]

Navigate to about:config and enable the Changes feat. ( devtools.inspector.changes.enabled - True) 


[STR]

1. Launch Firefox and open the Inspector.
2. Navigate to the 2nd pane and disable a property by deselecting the checkbox in front of it.
3. Observe this change being properly tracked in the Changes tab from the 3rd pane.
4. Select the disabled property name or value and hit the enter key. 
5. Hit the enter key again once the value is focused, or simply click anywhere in order to de-focus the last selection. 
6. Observe the previous tracked change (the disabling of the property) in the Changes tab.
7. Re-enable the property by checking the same checkbox from step 2, and observe the Changes tab again.

[AR]
The disabling of the property is properly tracked, but once the name or value of that particular property is browsed through using the enter key, the change is dismissed/removed from the Changes tab. Once the same property is re-enabled, the Changes tab, wrongly displays the adding of this property. 

This issue is not reproducible for an enabled property and is not influenced by the fact that the property is overridden or not.

I will attach a short video for better understanding.

[ER]
The disabling of the property remains visible until the user reverts his action, by re-enabling the property.

Comment 1

[Brad Werth [:bradwerth]]

Confirmed that I can reproduce this.