1504904 - --enable-default-toolkit=cairo-gtk3-wayland requires a Gtk with wayland backend

Status: RESOLVED FIXED

(Core :: Widget: Gtk, enhancement)

Description

[Mike Hommey [:glandium]]

While bug 1503592 makes the default backend used by such builds the X11 backend for now, the resulting build can't be used on a system with a Gtk3 without the wayland backend, because it uses the gdk_wayland_display_get_type symbol.

Comment 1

[Martin Stránský [:stransky] (ni? me)]

Attachment: Bug 1504904 - Provide fallback symbol gdk_wayland_display_get_type(), r=jhorak

Comment 2

[Martin Stránský [:stransky] (ni? me)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=2e01499baeac695622fc840d147301a49f61b210

Comment 3

[Martin Stránský [:stransky] (ni? me)]

New try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=bff7d7c39e11e3bd38849e4daebc52815e608d66

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/130c60233efa
Provide fallback symbol gdk_wayland_display_get_type(), r=jhorak

Comment 5

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/130c60233efa

Comment 6

[Mike Hommey [:glandium]]

This didn't fix anything. Now running on a Gtk without wayland support crashes in the wrapper that was added.

The stack trace looks like:

#0  0x0000555555564610 in mozalloc_abort ()
#1  0x0000555555564630 in abort ()
#2  0x00007ffff7dff2e9 in gdk_wayland_display_get_type () from /builds/worker/firefox/libmozwayland.so
#3  0x00007fffebe2585d in mozilla::widget::MakeScreen(_GdkScreen*, int) () from /builds/worker/firefox/libxul.so
#4  0x00007fffebe255b3 in mozilla::widget::ScreenHelperGTK::RefreshScreens() () from /builds/worker/firefox/libxul.so
#5  0x00007fffedc73bfc in nsAppShell::Init() () from /builds/worker/firefox/libxul.so
#6  0x00007fffebe4b3f6 in nsAppShellInit() () from /builds/worker/firefox/libxul.so

Presumably, that's because GDK_IS_WAYLAND_DISPLAY expands to G_TYPE_CHECK_INSTANCE_TYPE((obj), GDK_TYPE_WAYLAND_DISPLAY) where GDK_TYPE_WAYLAND_DISPLAY is gdk_wayland_display_get_type().

Comment 7

[Martin Stránský [:stransky] (ni? me)]

Attachment: Bug 1504904 - Don't use GDK_IS_WAYLAND_DISPLAY() as it's missing on Gtk+ X11 only builds, r=jhorak

Comment 8

[Martin Stránský [:stransky] (ni? me)]

Should be fine now, I checked libxul.so for the symbol and it not present there any more with this patch. Thanks.

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/05353b73a6ac
Don't use GDK_IS_WAYLAND_DISPLAY() as it's missing on Gtk+ X11 only builds, r=jhorak

Comment 10

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/05353b73a6ac