Closed Bug 1504904 Opened 2 years ago Closed 2 years ago
--enable-default-toolkit=cairo-gtk3-wayland requires a Gtk with wayland backend
47 bytes, text/x-phabricator-request
|Details | Review|
While bug 1503592 makes the default backend used by such builds the X11 backend for now, the resulting build can't be used on a system with a Gtk3 without the wayland backend, because it uses the gdk_wayland_display_get_type symbol.
Pushed by firstname.lastname@example.org: https://hg.mozilla.org/integration/autoland/rev/130c60233efa Provide fallback symbol gdk_wayland_display_get_type(), r=jhorak
This didn't fix anything. Now running on a Gtk without wayland support crashes in the wrapper that was added. The stack trace looks like: #0 0x0000555555564610 in mozalloc_abort () #1 0x0000555555564630 in abort () #2 0x00007ffff7dff2e9 in gdk_wayland_display_get_type () from /builds/worker/firefox/libmozwayland.so #3 0x00007fffebe2585d in mozilla::widget::MakeScreen(_GdkScreen*, int) () from /builds/worker/firefox/libxul.so #4 0x00007fffebe255b3 in mozilla::widget::ScreenHelperGTK::RefreshScreens() () from /builds/worker/firefox/libxul.so #5 0x00007fffedc73bfc in nsAppShell::Init() () from /builds/worker/firefox/libxul.so #6 0x00007fffebe4b3f6 in nsAppShellInit() () from /builds/worker/firefox/libxul.so Presumably, that's because GDK_IS_WAYLAND_DISPLAY expands to G_TYPE_CHECK_INSTANCE_TYPE((obj), GDK_TYPE_WAYLAND_DISPLAY) where GDK_TYPE_WAYLAND_DISPLAY is gdk_wayland_display_get_type().
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Attachment #9023577 - Attachment is obsolete: true
Should be fine now, I checked libxul.so for the symbol and it not present there any more with this patch. Thanks.
Pushed by email@example.com: https://hg.mozilla.org/integration/autoland/rev/05353b73a6ac Don't use GDK_IS_WAYLAND_DISPLAY() as it's missing on Gtk+ X11 only builds, r=jhorak
Status: REOPENED → RESOLVED
Closed: 2 years ago → 2 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.