1504931 - Android 7.0 x86 WPT started permafailing with various errors after bug 1504154

Status: RESOLVED FIXED

(Testing :: web-platform-tests, defect)

Description

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

I'm working on getting WPT running against Fennec on the x86 android emulator. Starting sometime after my push to try on early Sunday morning, every android wpt job started failing like [1].

Thinking I had maybe committed some syntax error causing things to catastrophically fail, I tried various older versions of my patch, but the jobs kept failing.

Then I pushed a few times with different base revisions.

The push based directly on top of bug 1504154 [2] fails like the other pushes, while the push on bug 1504154's parent [3] does not hit this failure (many chunks are still failing due to the expectation issues I've been working to clear up, but the tests actually get to run).

These tests are all still running successfully for me locally due to [4], but I'm not sure where to add grant_runtime_permissions() to have it included in CI wpt stuff. Maybe right after [5]?

1. https://treeherder.mozilla.org/logviewer.html#?job_id=209975574&repo=try
2. https://treeherder.mozilla.org/#/jobs?repo=try&tier=1%2C2%2C3&group_state=expanded&revision=bc8aad7b1124522098fb67f34ca187711613616c
3. https://treeherder.mozilla.org/#/jobs?repo=try&tier=1%2C2%2C3&group_state=expanded&revision=4dd4a46e3721d5592d143329175bf6d3c056c5a7
4. https://searchfox.org/mozilla-central/source/testing/web-platform/mach_commands.py#46
5. https://hg.mozilla.org/mozilla-central/file/tip/testing/mozharness/scripts/web_platform_tests.py#l313

Comment 1

[Geoff Brown [:gbrown]]

Attachment: use launch_activity instead of custom adb command

Rather than try to grant permissions in wpt code, this uses mozdevice's launch_ functions to start the application. Those include appropriate support for granting runtime permissions by default; this is also the approach used by mochitest and reftest.

At the same time, we can start preparing for geckoview (supporting bug 1496773).

https://treeherder.mozilla.org/#/jobs?repo=try&tier=1%2C2%2C3&selectedJob=210158771&revision=0b634c4d219db5bb1fc6d9606e871cb9ab69c754

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/4c0b9a5d991c
Use mozdevice.launch_activity to start fennec/geckoview in web-platform tests; r=kwierso

Comment 3

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/13959 for changes under testing/web-platform/tests

Comment 4

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream web-platform-tests status checks passed, PR will merge once commit reaches central.

Comment 5

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/4c0b9a5d991c

Comment 6

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged