1504951 - [Wayland] Clang plugin reports coding errors

Status: RESOLVED FIXED

(Core :: Widget: Gtk, enhancement)

Description

[Martin Stránský [:stransky] (ni? me)]

> clang plugin reports coding errors (you can try building 
> with clang and --enable-clang-plugin, but be aware that GCC miscompiles 
> clang in a way that breaks clang plugins, so make sure you use a clang 
> built with clang).

Comment 1

[Martin Stránský [:stransky] (ni? me)]

Hm, I'm unable to build with clang-plugin on Fedora 29. When the clang is supposed to use the plugin ld.so complains about missing std::_V2::error_category::~error_category() symbol. 

I have only mozilla provided clang/llvm installed except system llvm-libs-7.0.0-2.fc29.x86_64 / clang-libs-7.0.0-2.fc29.x86_64 - I wonder if that causes the problem.

Comment 2

[Martin Stránský [:stransky] (ni? me)]

Not sure if Bug 1428158 is related or not.

Comment 3

[Mike Hommey [:glandium]]

Attachment: Bug 1504951 - Fix static analysis errors that arise when enabling wayland support.

- Missing explicit to avoid implicit conversion constructors.
- Add a dummy use of an otherwise unused RefPtr that is used for RAII of
  a DBus object.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/18ea6c93e858
Fix static analysis errors that arise when enabling wayland support. r=jhorak

Comment 5

[Arthur Iakab [arthur_iakab]]

https://hg.mozilla.org/mozilla-central/rev/18ea6c93e858