1504971 - refactor rundsc.ps1 so that all processing happens inside a function

Status: RESOLVED FIXED

(Infrastructure & Operations :: RelOps: OpenCloudConfig, task)

Description

[Rob Thijssen [:grenade (EET/UTC+0300)]]

occ's rundsc.ps1 contains a fair amount of logic and decision trees that are not correctly logged in papertrail.

refactor the script so that all processing occurs inside of a function that includes appropriately verbose logging for the logic being processed.

all functions should take the form below so that we also collect processing time metrics for everything the script does:

function Verb-SomeFunction {
  param (
    ...
  )
  begin {
    Write-Log -message ('{0} :: begin - {1:o}' -f $($MyInvocation.MyCommand.Name), (Get-Date).ToUniversalTime()) -severity 'DEBUG'
  }
  process {
    ...
  }
  end {
    Write-Log -message ('{0} :: end - {1:o}' -f $($MyInvocation.MyCommand.Name), (Get-Date).ToUniversalTime()) -severity 'DEBUG'
  }
}

Comment 1

[Rob Thijssen [:grenade (EET/UTC+0300)]]

Attachment: GitHub Pull Request

added functions for:

- Set-ServiceState
- Set-DomainName
- Set-DynamicDnsRegistration
- Run-MaintainSystem
- Run-RemoteDesiredStateConfig
- Set-ComputerName

wrapped everything else in:

- Run-OpenCloudConfig

this last mega function still needs a lot of refactoring into smaller methods.

Comment 2

[Rob Thijssen [:grenade (EET/UTC+0300)]]

merged with the sha pinning changes:
https://github.com/mozilla-releng/OpenCloudConfig/commit/9d74a89cadd596ffc7f5f0762d838ff4dd6651dc