Closed Bug 1505069 Opened 2 years ago Closed 2 years ago

Contextual Feature Recommendation popup-notification abuses --lwt-text-color

Categories

(Firefox :: Theme, defect, P1)

defect

Tracking

()

RESOLVED FIXED
Firefox 65
Tracking Status
firefox-esr60 --- unaffected
firefox63 --- wontfix
firefox64 --- fixed
firefox65 --- fixed

People

(Reporter: dao, Assigned: dao)

References

Details

(Keywords: regression)

Attachments

(1 file)

Not sure why --lwt-text-color was picked here. For starters, this is only set in the case of a webextension theme, end even then this won't necessarily do the right thing.
Pushed by dgottwald@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/c9f8111643e1
Stop abusing --lwt-text-color in the Contextual Feature Recommendation popup-notification. r=Mardak
https://hg.mozilla.org/mozilla-central/rev/c9f8111643e1
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 65
Comment on attachment 9022987 [details]
Bug 1505069 - Stop abusing --lwt-text-color in the Contextual Feature Recommendation popup-notification. r?Mardak

[Beta/Release Uplift Approval Request]

Feature/Bug causing the regression: bug 1486779

User impact if declined: the Contextual Feature Recommendation notification's link in the header and stars in the footer may be illegible, depending on user settings

Is this code covered by automated tests?: No

Has the fix been verified in Nightly?: No

Needs manual test from QE?: No

If yes, steps to reproduce: -

List of other uplifts needed: -

Risk to taking this patch: Low

Why is the change risky/not risky? (and alternatives if risky): trivial fix

String changes made/needed: -
Attachment #9022987 - Flags: approval-mozilla-beta?
Blocks: 1485422
Comment on attachment 9022987 [details]
Bug 1505069 - Stop abusing --lwt-text-color in the Contextual Feature Recommendation popup-notification. r?Mardak

css fix for CFR popup, approved for 64.0b8
Attachment #9022987 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
You need to log in before you can comment on or make changes to this bug.