1505069 - Contextual Feature Recommendation popup-notification abuses --lwt-text-color

Status: RESOLVED FIXED

(Firefox :: Theme, defect, P1)

Description

[Dão Gottwald [:dao]]

Not sure why --lwt-text-color was picked here. For starters, this is only set in the case of a webextension theme, end even then this won't necessarily do the right thing.

Comment 1

[Dão Gottwald [:dao]]

Attachment: Bug 1505069 - Stop abusing --lwt-text-color in the Contextual Feature Recommendation popup-notification. r?Mardak

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c9f8111643e1
Stop abusing --lwt-text-color in the Contextual Feature Recommendation popup-notification. r=Mardak

Comment 3

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/c9f8111643e1

Comment 4

[Dão Gottwald [:dao]]

Comment on attachment 9022987 [details]
Bug 1505069 - Stop abusing --lwt-text-color in the Contextual Feature Recommendation popup-notification. r?Mardak

[Beta/Release Uplift Approval Request]

Feature/Bug causing the regression: bug 1486779

User impact if declined: the Contextual Feature Recommendation notification's link in the header and stars in the footer may be illegible, depending on user settings

Is this code covered by automated tests?: No

Has the fix been verified in Nightly?: No

Needs manual test from QE?: No

If yes, steps to reproduce: -

List of other uplifts needed: -

Risk to taking this patch: Low

Why is the change risky/not risky? (and alternatives if risky): trivial fix

String changes made/needed: -

Comment 5

[Julien Cristau [:jcristau]]

Comment on attachment 9022987 [details]
Bug 1505069 - Stop abusing --lwt-text-color in the Contextual Feature Recommendation popup-notification. r?Mardak

css fix for CFR popup, approved for 64.0b8

Comment 6

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/releases/mozilla-beta/rev/f9e1cbdcab70