Contextual Feature Recommendation popup-notification abuses --lwt-text-color

RESOLVED FIXED in Firefox 64

Status

()

defect
P1
normal
RESOLVED FIXED
7 months ago
7 months ago

People

(Reporter: dao, Assigned: dao)

Tracking

({regression})

Trunk
Firefox 65
Points:
---
Dependency tree / graph
Bug Flags:
qe-verify -

Firefox Tracking Flags

(firefox-esr60 unaffected, firefox63 wontfix, firefox64 fixed, firefox65 fixed)

Details

Attachments

(1 attachment)

Assignee

Description

7 months ago
Not sure why --lwt-text-color was picked here. For starters, this is only set in the case of a webextension theme, end even then this won't necessarily do the right thing.

Comment 2

7 months ago
Pushed by dgottwald@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/c9f8111643e1
Stop abusing --lwt-text-color in the Contextual Feature Recommendation popup-notification. r=Mardak
Assignee

Updated

7 months ago

Comment 3

7 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/c9f8111643e1
Status: ASSIGNED → RESOLVED
Last Resolved: 7 months ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 65
Assignee

Comment 4

7 months ago
Comment on attachment 9022987 [details]
Bug 1505069 - Stop abusing --lwt-text-color in the Contextual Feature Recommendation popup-notification. r?Mardak

[Beta/Release Uplift Approval Request]

Feature/Bug causing the regression: bug 1486779

User impact if declined: the Contextual Feature Recommendation notification's link in the header and stars in the footer may be illegible, depending on user settings

Is this code covered by automated tests?: No

Has the fix been verified in Nightly?: No

Needs manual test from QE?: No

If yes, steps to reproduce: -

List of other uplifts needed: -

Risk to taking this patch: Low

Why is the change risky/not risky? (and alternatives if risky): trivial fix

String changes made/needed: -
Attachment #9022987 - Flags: approval-mozilla-beta?
Assignee

Updated

7 months ago
Blocks: 1485422
Comment on attachment 9022987 [details]
Bug 1505069 - Stop abusing --lwt-text-color in the Contextual Feature Recommendation popup-notification. r?Mardak

css fix for CFR popup, approved for 64.0b8
Attachment #9022987 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
You need to log in before you can comment on or make changes to this bug.