1505141 - Editing an existing address with shipping and contact fields from the contact/payer form will blank address fields

Status: VERIFIED FIXED

(Firefox :: WebPayments UI, defect, P1)

Description

[Matthew N. [:MattN]]

STR:
1) Visit a page with requestShipping, requestPayerPhone and requestPayerEmail (you can test with https://paymentrequest.show/demo/ )
2) Add a shipping address with both shipping address fields and the optional telephone number (the profile shouldn't have an email at this time as it's new).
3) Use the same address in the payer/contact dropdown (identified by the phone number)
4) Edit the contact information to add your email address to the record
5) Click Update

Expected result:
The email address should get added to the existing address record

Actual result:
The address record now only consists of the email and telephone number, the address fields are blanked.

The regression cause is https://hg.mozilla.org/mozilla-central/rev/95fe4f9c32033b78245886e1e83f70675624977b#l1.12

I think we can use a different approach of looking at `getFormFormat` to know which fields are applicable for the country.

Comment 1

[Matthew N. [:MattN]]

Attachment: Bug 1505141 - Always preserveOldProperties for payment request but blank mailing address fields by default. r=jaws

Comment 2

[Matthew N. [:MattN]]

Attachment: Bug 1505141 - Test that address fields hidden from edit forms aren't blanked unnecessarily. r=jaws

Depends on D12190

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4f693fc02c24
Always preserveOldProperties for payment request but blank mailing address fields by default. r=jaws
https://hg.mozilla.org/integration/autoland/rev/5128dd79f222
Test that address fields hidden from edit forms aren't blanked unnecessarily. r=jaws

Comment 4

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/4f693fc02c24
https://hg.mozilla.org/mozilla-central/rev/5128dd79f222

Comment 5

[Hani Yacoub, Desktop QA]

Verified as fixed on Firefox Nightly 65.0a1 (2018-11-25) on Windows 10 x 64, Windows 7 x32, Mac OS X 10.13 and on Ubuntu 16.04 x64.