Closed Bug 1420853 Opened 7 years ago Closed 6 years ago

Ensure only fields valid for the given country are saved

Categories

(Toolkit :: Form Autofill, defect, P1)

Product:
Toolkit
Component:
Form Autofill
Type:
defect

Tracking

()

Status:
VERIFIED FIXED
Milestone:
mozilla64
Tracking Flags:
Tracking Status
firefox64 --- verified

People

(Reporter: scottwu, Assigned: jaws)

References

(Blocks 2 open bugs)

Details

(Whiteboard: [webpayments] [form autofill:V2])

Attachments

(1 file, 1 obsolete file)

Bug 1420853 - Ensure only fields valid for the given country are saved. r?MattN
46 bytes, text/x-phabricator-request
Details | Review
For countries like Germany, which doesn't fill address-level1 (province), there's a chance we'd inadvertently populate address-level1 if the field is not empty. STR: 1. Set country to US 2. Fill the State field 3. Change country to Germany 4. Save address The hidden address-level1 field (previously State) probably shouldn't be saved as part of a German address.
Whiteboard: [form autofill:V2]
Assignee: nobody → scwwu
Comment on attachment 8942597 [details] Bug 1420853 - Ensure only fields valid for the given country are saved. https://reviewboard.mozilla.org/r/212862/#review219138
Attachment #8942597 - Flags: review?(lchang) → review+
Whiteboard: [form autofill:V2] → [form autofill:V2] [webpayments]
Priority: -- → P3
Status: NEW → ASSIGNED
Priority: P3 → P1
Whiteboard: [form autofill:V2] [webpayments] → [form autofill:V2] [webpayments-reserve]
Another issue worth to mention that could be handled here: Editing an already saved address from DE to US populate the state field automatically STR: 1. Go to "https://rsolomakhin.github.io/pr/single/" and click on "Buy" button. 2. Edit an already saved shipping address country from US to DE. 3. Edit the same shipping address and change the country again from DE to US.
Assignee: scottcwwu → nobody
Status: ASSIGNED → NEW
Priority: P1 → P3
Whiteboard: [form autofill:V2] [webpayments-reserve] → [webpayments-reserve] [form autofill:V2]
Flags: qe-verify?
Priority: P3 → P2
Whiteboard: [webpayments-reserve] [form autofill:V2] → [webpayments] [form autofill:V2]
Flags: qe-verify? → qe-verify+
QA Contact: hani.yacoub
Assignee: nobody → jaws
Status: NEW → ASSIGNED
Priority: P2 → P1
This patch is a completion of the work done by Scott Wu.
Attachment #8942597 - Flags: review?(steveck324)
Attachment #8942597 - Attachment is obsolete: true
Pushed by jwein@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/95fe4f9c3203 Ensure only fields valid for the given country are saved. r=MattN
https://hg.mozilla.org/mozilla-central/rev/95fe4f9c3203
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
status-firefox64: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla64
Verified as fixed on Firefox Nightly 64.0a1 (2018-10-22) on Windows 10 x 64, Windows 7 x32, Mac OS X 10.13 and on Ubuntu 16.04 x64.
Status: RESOLVED → VERIFIED
status-firefox64: fixed → verified
Flags: qe-verify+
Depends on: 1505141
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: