150519 - Search results from http://www.google.co.il/ print in horrible quality

Status: RESOLVED FIXED

(Core Graveyard :: Printing: Xprint, defect)

Description

[Roland Mainz]

Trying to print http://www.google.co.il/search?q=mozilla&hl=iw looks horrible
since it seems to pick mainly one of these two fonts to render the results:
-misc-fixed-medium-r-semicondensed--0-0-75-75-c-0-iso8859-1
-misc-fixed-medium-r-semicondensed--13-120-75-75-c-60-iso8859-1

The problem is burried in the detail that the page _forces_ the use of the
-*--*-*-*-*-c-*-* fonts.

Comment 1

[Roland Mainz]

Taking myself...

Comment 2

[Roland Mainz]

Upcoming patch was created after applying patch from bug 148470 ('Ban "-dt-*"
(bitmap!!) fonts from Xprint') and needs working Xprint font banning code (bug
148468 - 'Xprint-specific X font banning code is broken') ...

Comment 3

[Roland Mainz]

Attachment: Patch for 2002-06-07-08-trunk, ban all fonts with *--$(number>0)-$(number>0)-$(number>0)-$(number>0)-c-*

Comment 4

[Roland Mainz]

Another - better solution may be to find PS Type1 version of the "-c-" fonts...
however a Google search indicated that there is no such font... ;-(

Comment 5

[Roland Mainz]

shanjian:
Can you r= the patch, please ?

Comment 6

[Roland Mainz]

Comment on attachment 87067 [details] [diff] [review]
Patch for 2002-06-07-08-trunk, ban all fonts with *--$(number>0)-$(number>0)-$(number>0)-$(number>0)-c-*

Patch needs minor adjustments since iz bans all fonts from
/usr/openwin/lib/locale/ja/X11/fonts/75dpi/ ... ;-(

Comment 7

[Roland Mainz]

Attachment: Better patch for 2002-06-07-08-trunk

I am limiting the ban now to iso8859-* encodings since they have tons of other
fonts which fit here "better".
Non iso8859-* still can use all *-c-* bitmap fonts fonts...

Note that the patch does not affect outline-scaleable fonts, this patch bans
only bitmap fonts...

Comment 8

[Shanjian Li]

Roland,
You might want to limit you banned list within iso8859-* as well. iso8859-1
fonts are abundant. Things are probably for iso8859-2 (east european). Other
than that, I have no idea. 

BTW, if the fonts in your rejected list are the only fonts available for certain
encoding, are those fonts still rejected?

Comment 9

[Roland Mainz]

Shanjian Li wrote:
> You might want to limit you banned list within iso8859-* as well. iso8859-1
> fonts are abundant. Things are probably for iso8859-2 (east european). Other
> than that, I have no idea.

The new patch (attachment 87125 [details] [diff] [review]) contains already such a "ban" which is limited
to the iso8859-[0123456789]* fonts (otherwise we ban the janapese 75DPI bitmap
fonts on Solaris (which is bad on Solaris 2.7 since it does not come with other
fonts for japanese)).
Or do you mean I should restrict the ban in a further way ?

> BTW, if the fonts in your rejected list are the only fonts available for 
> certain encoding, are those fonts still rejected?

Our X font ban's are final. They are banned forever.

Comment 10

[Shanjian Li]

Yes, that's what I mean. For example, iso8859-11 is Thai, and I believe very few
fonts available, even fewer than japanese. So you might want to do the same
thing to this encoding as well. Since your ban is final, I would suggest to ban
iso8859-1, iso8859-2, iso8859-15. Don't ban other encoding until we hear
complaints. 

Comment 11

[Roland Mainz]

Shanjian Li wrote:
> Don't ban other encoding until we hear complaints.

Agreed... :)

Comment 12

[Roland Mainz]

More fun... further testing shows that our code treats the -misc-fixed-* bitmap
fonts as outline-scaleable fonts (!!) and therefore bypasses all
tricks&safeguards which should prevent scaleable bitmap fonts (even bug 148690
'RFE: For Xprint force use of outline scaleable fonts if possible') ... ;-(

Comment 13

[Roland Mainz]

Attachment: Patch for 2002-06-07-08-trunk to kill the root of the bitmap-font-evilness

Very simple issue:
The code which looks for printer-builtin fonts is slightly wrong.

Comment 14

[Roland Mainz]

Attachment: Better patch for 2002-06-07-08-trunk to kill the root of the bitmap-font-evilness and updating the comment about printer-builtin fonts

Comment 15

[Roland Mainz]

Sorry for my wrong assumtions in the previous comments... looks I was trying to
cure the symptoms and not the root of the problem... ;-(

----

Requesting r=/sr= ...

Comment 16

[Shanjian Li]

Comment on attachment 87195 [details] [diff] [review]
Better patch for 2002-06-07-08-trunk to kill the root of the bitmap-font-evilness and updating the comment about printer-builtin fonts

r=shanjian, simple is better, and more likely to reveal the truth.

Comment 17

[Johnny Stenback (:jst)]

Comment on attachment 87195 [details] [diff] [review]
Better patch for 2002-06-07-08-trunk to kill the root of the bitmap-font-evilness and updating the comment about printer-builtin fonts

sr=jst

Comment 18

[Roland Mainz]

Removing dependicy on bug 148468 and bug 148470 since the new patch does not
require them...

Comment 19

[Simon Montagu :smontagu]

Checked in to trunk for Roland

Comment 20

[Roland Mainz]

Requesting a= for 1.0.1-branch...

Comment 21

[Randell Jesup [:jesup] (needinfo me)]

Comment on attachment 87195 [details] [diff] [review]
Better patch for 2002-06-07-08-trunk to kill the root of the bitmap-font-evilness and updating the comment about printer-builtin fonts

Approved for 1.0 branch.  Please remove mozilla1.0.1+ when it's fixed and add
fixed1.0.1

Comment 22

[Simon Montagu :smontagu]

checked in to branch