Closed Bug 1505790 Opened 2 years ago Closed 2 years ago

toolkit/mozapps/update/tests/browser/browser_updatesBackgroundWindow.js | A promise chain failed to handle a rejection: win.gBrowser is undefined; can't access its "tabs" property when Gecko 65 merges to Beta on 2018-12-03

Categories

(Toolkit :: Application Update, defect)

defect
Not set
normal

Tracking

()

VERIFIED FIXED
mozilla65
Tracking Status
firefox-esr60 --- unaffected
firefox63 --- unaffected
firefox64 --- unaffected
firefox65 + verified

People

(Reporter: stefan_hindli, Assigned: robert.strong.bugs)

Details

Attachments

(1 file, 2 obsolete files)

It showed up in an earlier version of the patch for bug 1458308, the patch was changed, and it didn't show up in later versions
https://treeherder.mozilla.org/#/jobs?repo=try&revision=48b9aec5261e75a10b3365ab56838f60c58aa56e

I don't think this has anything to do with bug 1458308.
Also, bug 1458308 didn't land on beta so this doesn't have anything to do with bug 1458308.
No longer blocks: update-prefs
Flags: needinfo?(ksteuber)
Beta simulations are done with central, not with beta. They take the code from central and run with beta configurations.
So, this is in regards to the mozilla-central merge to mozilla-beta and not concerned with current beta.

I was suspicious of the actual code that is failing and will look into it.
irc convo today

rstrong> jaws: not sure who to talk with about this. I have a test that was converted to async and is now intermittently failing in code in nsBrowserGlue.js in unrelated code with A promise chain failed to handle a rejection: win.gBrowser is undefined; can't access its "tabs" property - stack:
<rstrong> BG__setSyncAutoconnectDelay@jar:file:///Z:/task_1541678884/build/application/firefox/browser/omni.ja!/components/nsBrowserGlue.js:637:7
<rstrong> https://dxr.mozilla.org/mozilla-central/source/browser/components/nsBrowserGlue.js#634
<rstrong> jaws: tempted to just add a check for win.gBrowser there
<•jaws> looking at the code...
<•jaws> this code is so arbitrary
<•jaws> like why 1 second delay for each tab?
<•jaws> rstrong: i'd be fine with replacing that with something else, thinking about what else now
<•MattN> you could workaround by setting the services.sync.autoconnectDelay pref in your test
<•jaws> rstrong: for your test can you set services.sync.autoconnectDelay ?
<•jaws> yes, same as what mattn said
<rstrong> jaws: definitely and if you are fine with that I am :)
<•jaws> rstrong: yeah i'm fine with setting the pref
Attached patch patch rev1 (obsolete) — Splinter Review
Assignee: nobody → robert.strong.bugs
Status: NEW → ASSIGNED
Attachment #9023753 - Flags: review?(ksteuber)
Attached patch patch rev1 (obsolete) — Splinter Review
Just fixed a comment
Attachment #9023753 - Attachment is obsolete: true
Attachment #9023753 - Flags: review?(ksteuber)
Attachment #9023754 - Flags: review?(ksteuber)
Attachment #9023754 - Flags: review?(ksteuber) → review+
Pushed by rstrong@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/3b764f11b980
Fix intermittent failure of browser_updatesBackgroundWindow.js. r=bytesize
https://hg.mozilla.org/mozilla-central/rev/3b764f11b980
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla65
Attached patch patch rev2Splinter Review
The previous patch didn't set the pref for browser_updateAutoPrefUI.js since it doesn't call runUpdateTest.
Attachment #9023754 - Attachment is obsolete: true
Flags: needinfo?(robert.strong.bugs)
Attachment #9024134 - Flags: review?(ksteuber)
Note: the reason browser_updateAutoPrefUI.js is that browser_updatesBackgroundWindow.js immediately follows browser_updateAutoPrefUI.js in the test run and the call from sync that isn't able to find the tabs property happens in that test.
Attachment #9024134 - Flags: review?(ksteuber) → review+
Pushed by rstrong@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/999652c2fc2b
Second attempt to fix Bug 1505790 - Fix intermittent failure of browser_updatesBackgroundWindow.js. r=bytesize
aryx, could you do another push and include this patch? Thanks!
Flags: needinfo?(aryx.bugmail)
FYI: there are other tests that intermittently fail like this one did. Bug 1506271
https://hg.mozilla.org/mozilla-central/rev/999652c2fc2b
Status: REOPENED → RESOLVED
Closed: 2 years ago2 years ago
Resolution: --- → FIXED
It moved from bc2 to bc5 and didn't fail any of 26 runs (it's perma orange due to a different failing test): https://treeherder.mozilla.org/#/jobs?repo=try&revision=e9150112ebed08f3a278e28259c4683a44ba8e31&selectedJob=211201245
Flags: needinfo?(aryx.bugmail)
That permaorange test actually runs before this test or any of the update tests so it looks like this bug is fixed.
You need to log in before you can comment on or make changes to this bug.