1505915 - [Fission] Make View Source Fission-aware

Status: RESOLVED FIXED

(Toolkit :: View Source, task, P3)

Description

[:Felipe Gomes (needinfo for replies!)]

The test toolkit/components/viewsource/test/browser/browser_srcdoc.js fails when using the browser.fission.simulate pref.

I didn't dig deeper yet, but it's likely that the feature will need more changes to be compatible with Fission, related to viewing the source of subframes (This Frame -> View Source) and View Selection Source

Comment 1

[Chris Peterson [:cpeterson]]

M4.1 because this bug is about a test. View Source works for me in the browser.

Comment 2

[Chris Peterson [:cpeterson]]

Honza, this bug currently blocks Fission's current milestone (M4.1 aka "fix all the mochitests"), but it's unassigned.

Is this bug still valid? View Source works for me in the browser and the browser_srcdoc.js mentioned in comment 0 does not appear to be skipped or fail-if Fission:

https://searchfox.org/mozilla-central/rev/6305f6935f496b3a302c7afcc579399a4217729c/toolkit/components/viewsource/test/browser/browser.ini#12

Comment 3

[Chris Peterson [:cpeterson]]

Part of fixing this Fission View Source bug is removing fails-if(browserIsFission) from the view-source:bug482921-2.xhtml reftest (added in bug 1602322):

https://hg.mozilla.org/mozilla-central/diff/f54c5e870f23c34617fda96fb13b3dfe75860dc6/parser/htmlparser/tests/reftest/reftest.list

Comment 4

[Neil Deakin]

I have a patch for this. View Source works fine as is, but viewing a child frame's source from the context menu does not.

The test bug482921-2.xhtml isn't marked as disabled for fission. Some of the others in that reftest.list are but don't look to be related to view source, so i don't think there is anything to do here testwise.

Comment 5

[Neil Deakin]

Attachment: Bug 1505915, move view source components to use JSWindowActor. This allows view frame source to work in out of process child frames, r=mconley

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/deea1e560289
move view source components to use JSWindowActor. This allows view frame source to work in out of process child frames, r=mconley

Comment 7

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/deea1e560289