1602323 - (R-fis) [meta] Fix R-fis reftest failures

Status: RESOLVED FIXED

(Core :: Layout, defect, P5)

Description

[Matt Woodrow (:mattwoodrow)]

Bug 1602322 will enable data URI <iframe>s in their own process, and exposes a number of rendering issues with fission.

I'm marking these with fails-if(browserIsFission) for now to keep the tests green.

We should investigate the causes of these, and make sure we fix critical ones for fission milestone M5.

Comment 1

[Matt Woodrow (:mattwoodrow)]

Failures that need fixing: https://searchfox.org/mozilla-central/search?q=browserIsFission&case=false&regexp=false&path=list

Comment 2

[Chris Peterson [:cpeterson]]

Tracking for Fission Nightly (M6)

Comment 3

[Chris Peterson [:cpeterson]]

(In reply to Matt Woodrow (:mattwoodrow) from comment #1)

Failures that need fixing: https://searchfox.org/mozilla-central/search?q=browserIsFission&case=false&regexp=false&path=list

jbonisteel says she (Gfx) and svoisen (Layout) will triage these Fission reftest failures in January.

Comment 4

[Timothy Nikkel (:tnikkel)]

Curious why you added bug 1392106 dependency? Are you finding that fission is hit harder by that then non-fission?

Comment 5

[Chris Peterson [:cpeterson]]

(In reply to Timothy Nikkel (:tnikkel) from comment #4)

Curious why you added bug 1392106 dependency? Are you finding that fission is hit harder by that then non-fission?

I added bug 1392106 because the test was marked as fails-if(browserIsFission) (by bug 1602322). I suspect this test was marked fails-if for Fission because Fission doesn't support View Source yet (bug 1505915).

Since bug 1392106 is a longstanding intermittent failure, I'll unlink it from this bug and then mention the test's fails-if(browserIsFission) in View Source bug 1505915.

Comment 6

[Timothy Nikkel (:tnikkel)]

I looked through all the failures (on Linux at least) and classified them.

306660-3.html
459443-1.html
bug945215-2.html
-various test that have an iframe or frameset and use reftest-wait painting nothing in the test iframe/frameset
-bug in the fission reftest harness code?

bug945215-2.html
bug608373-1.html
bug659763-*.html (not filed)
bug696651-2.html
262998-1.html
bug863728-2.html
bug945215-2.html
-various tests that have an iframe and use reftest-wait paint iframe contents slightly shifted with webrender only
-webrender bug?

818276-1.html
-iframe with reftest-wait, contents of iframe not in reftest snapshot, even what would be in the snapshot before we start waiting for reftest-wait, webrender only
-either one of the above two or both?

474472-1.html
-test does not drawn green background color for a few lines of pixels on the top and left of iframe (reftest-wait)

841192-1.html
-larger strips of background color inside frameset are not drawn on top and left

370422-1.html (not filed)
-button in iframe, looks like we are not drawing the right half of it, both test and ref is dynamically modified but not reftest-wait

layout/reftests/border-radius/iframe-1.html
-we don't seem to support border radius on fission oop iframes

position-fixed-iframe-*.html
-need to support various reftest displayport and sync scroll attributes in fission oop iframes
-I've started on this

frame-scrolling-attr
-scrolling="" attribute is not supported
-looks like Emilio is working on this

Comment 7

[Timothy Nikkel (:tnikkel)]

I now have patches for all failures except the border radius applied to a oop fission iframe test.

Comment 8

[Timothy Nikkel (:tnikkel)]

(In reply to Timothy Nikkel (:tnikkel) from comment #7)

I now have patches for all failures except the border radius applied to a oop fission iframe test.

Patches up for border radius applied to an oop fission iframe now!

Comment 9

[Timothy Nikkel (:tnikkel)]

Attachment: Bug 1602323. Mark a few reftests as passing with fission now.

I forgot to mark them passing when I landed the patches that fixed them.

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5a2f9aebd4f0
Mark a few reftests as passing with fission now.

Comment 11

[Andrei Ciure[:aciure]]

https://hg.mozilla.org/mozilla-central/rev/5a2f9aebd4f0

Comment 12

[Chris Peterson [:cpeterson]]

Tracking for Fission M6b Nightly.

Comment 13

[Neha Kochar [:neha]]

Meta is M7 but individual bugs may be higher priority for Fission.

Comment 14

[Timothy Nikkel (:tnikkel)]

All fixed now.