1505950 - Lightning doesn't allow to save password for CalDAV

Status: RESOLVED FIXED

(Calendar :: Provider: CalDAV, defect)

Description

[Antoine Turmel [:GeekShadow]]

Attachment: Behaviour on stable Thunderbird 60.3.0 on Windows

On Thunderbird 64.0b1 when you add a CalDAV calendar that required a password/login, there is no more a checkbox to save the password in the password manager.

I'm not sure if it's a Thunderbird bug or rather a Lightning issue.

Comment 1

[Antoine Turmel [:GeekShadow]]

Attachment: Behaviour on beta Thunderbird 64.0b1 on Windows

Comment 3

[[:MakeMyDay]]

Can you check on Daily whether this is still an issue now that bug 1476330 has landed?

Comment 4

[Eckard Berberich]

It is still an issue here (macOS High Sierra) in the latest build of Daily (see my attachment).

Comment 5

[Eckard Berberich]

Attachment: Checkbox missing in Thunderbird Daily 65.0a1 (2018-11-16).png

Comment 6

[[:MakeMyDay]]

If that is still an issue after bug 1476330 has landed, I'm wondering if this is an issue on esr60, too, since the last real change in cal.auth.utils was uplifted to esr.

If esr60 is fine, it's probably not a lightning regression but some changes in core we still have to follow-up with.

Comment 7

[Eckard Berberich]

Thunderbird 60.3.0 and 63.0b1 are fine.

Comment 8

[[:MakeMyDay]]

Thanks. Is the checkbox available in 64 beta for other types of accounts, e.g. imap or pop?

Comment 9

[Eckard Berberich]

Yes, it is.

Comment 10

[Antoine Turmel [:GeekShadow]]

(In reply to [:MakeMyDay] from comment #3)
> Can you check on Daily whether this is still an issue now that bug 1476330
> has landed?

It's still an issue yes...

Comment 11

[Geoff Lankow (:darktrojan)]

Attachment: 1505950-prompt-save-password-1.diff

Comment 12

[Philipp Kewisch [:Fallen][📱📆]]

Comment on attachment 9032065 [details] [diff] [review]
1505950-prompt-save-password-1.diff

Review of attachment 9032065 [details] [diff] [review]:
-----------------------------------------------------------------

The code looks reasonable, but why did this break?

Comment 13

[Geoff Lankow (:darktrojan)]

I don't know, but I suspect it has something to do with the master password bug 682474, which is in the timeframe.

Comment 14

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/3375b11b89fa
Ask to save password for CalDAV calendars; r=Fallen

Comment 15

[Antoine Turmel [:GeekShadow]]

Is it possible to land the patch in the 65.0 beta channel of Thunderbird ? (Lightning 6.7)

Comment 16

[[:MakeMyDay]]

Can you please confirm that it works as expected on Daily, please? When doing so, please make sure to use a separate profile than on beta.

Comment 17

[Eckard Berberich]

I confirm that it works as expected on Daily 66 in a new separate profile.
macOS 10.13.6

Comment 18

[Antoine Turmel [:GeekShadow]]

(In reply to [:MakeMyDay] from comment #16)

Can you please confirm that it works as expected on Daily, please? When doing so, please make sure to use a separate profile than on beta.

I confirm it works as well on Daily 66 (20190114) on Windows 10 x64 with a fresh profile