1505955 - Convert Perf models to ReactJS

Status: RESOLVED FIXED

(Tree Management :: Perfherder, defect)

Description

[Sarah Clements [:sclements]]

This would include the PhIssueTracker, PhFramework and PhAlerts (might be best to open a separate pr for the latter) in the `js/models/perf` folder. The PhIssueTracker and PhFramework's classes/method can probably be removed and replaced with the `getData` helper in `ui/helpers/url.js`. API route names can be stored in the new `perfherder/constants.js` file.

The PhAlert classes can probably be made as helper functions and moved into the `perfherder/helpers.js` file (even if temporarily, since many will likely move to future components).

Comment 1

[GitHub Bugzilla PR Linker]

Attachment: Link to GitHub pull-request: https://github.com/mozilla/treeherder/pull/4261

Comment 2

[Ionuț Goldan [:igoldan]]

Comment on attachment 9024379 [details] [review]
Link to GitHub pull-request: https://github.com/mozilla/treeherder/pull/4261

I'm close to finishing this bug. Some Selenium test are failing; maybe there are some Angular digest calls needed.

Comment 3

[Sarah Clements [:sclements]]

Comment on attachment 9024379 [details] [review]
Link to GitHub pull-request: https://github.com/mozilla/treeherder/pull/4261

I left a comment on your pr. For future reference, it's helpful to know what steps you already took to try solving the problem so there isn't a duplicate of effort :)

Comment 4

[Treeherder GitHub Bugbot]

Commit pushed to master at https://github.com/mozilla/treeherder

https://github.com/mozilla/treeherder/commit/6c72fb310d067e7736b9c5d7cbefaafbe0829662
Bug 1505955 - Replace PhFramework and PhIssueTracker with getData() (#4261)