1506553 - Convert PhAlerts model to ReactJS

Status: RESOLVED FIXED

(Tree Management :: Perfherder, enhancement)

Description

[Ionuț Goldan [:igoldan]]

This splits up the task defined in https://bugzilla.mozilla.org/show_bug.cgi?id=1505955#c0

Comment 1

[GitHub Bugzilla PR Linker]

Attachment: Link to GitHub pull-request: https://github.com/mozilla/treeherder/pull/4263

Comment 2

[Ionuț Goldan [:igoldan]]

Comment on attachment 9024445 [details] [review]
Link to GitHub pull-request: https://github.com/mozilla/treeherder/pull/4263

I want to know whether I'm on the right track with the PhAlerts factory, according to your guidelines from https://bugzilla.mozilla.org/show_bug.cgi?id=1505955#c0

Comment 3

[Sarah Clements [:sclements]]

Comment on attachment 9024445 [details] [review]
Link to GitHub pull-request: https://github.com/mozilla/treeherder/pull/4263

Yes you're on the right track :) I left comments on your pr.

Comment 4

[Ed Morley [:emorley]]

Comment on attachment 9024445 [details] [review]
Link to GitHub pull-request: https://github.com/mozilla/treeherder/pull/4263

Looks good at first glance - though will defer to Sarah/Cameron for more detailed review :-)

Thank you for working on this!

Comment 5

[Sarah Clements [:sclements]]

Comment on attachment 9024445 [details] [review]
Link to GitHub pull-request: https://github.com/mozilla/treeherder/pull/4263

Looks good overall but the console error should be looked into. :)

Comment 6

[Treeherder GitHub Bugbot]

Commit pushed to master at https://github.com/mozilla/treeherder

https://github.com/mozilla/treeherder/commit/7c3769efbe7840932e319218bfd1eb7daf109a25
Bug 1506553 - Convert PhAlerts model to ReactJS (#4263)