Add redirection for rand()

RESOLVED FIXED in Firefox 65

Status

()

RESOLVED FIXED
5 months ago
4 months ago

People

(Reporter: bhackett, Assigned: bhackett)

Tracking

(Blocks: 1 bug)

unspecified
mozilla65
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox65 fixed)

Details

Attachments

(1 attachment)

(Assignee)

Description

5 months ago
Posted patch patchSplinter Review
While in a single threaded context we should be able to control for the random number seed and generate the same sequence of numbers, there are several ways in which we could fail to replay the numbers exactly --- if rand() is called while events are passed through, or if it is called from multiple threads whose accesses aren't synchronized.  The attached patch adds a redirection to ensure that rand() calls always produce the same value.
Attachment #9023802 - Flags: review?(lsmyth)
Attachment #9023802 - Flags: review?(lsmyth) → review+

Comment 2

4 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/fa47f2e5c1fb
Status: NEW → RESOLVED
Last Resolved: 4 months ago
status-firefox65: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla65
(Assignee)

Comment 3

4 months ago
This patch broke Web Replay on 10.13 (and possibly other versions), backing out for now.

https://hg.mozilla.org/integration/mozilla-inbound/rev/c418b8e31eacc847c27c03c4636ce3315c0c7e2f
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
(Assignee)

Updated

4 months ago
Depends on: 1506280
(Assignee)

Updated

4 months ago
Depends on: 1506311
(Assignee)

Comment 5

4 months ago
It turns out this patch never broke things after all (after backing it out 10.13 was still broken), but the problem was with the CGColorSpaceCreateDeviceGray redirection added by bug 1505922.

Comment 6

4 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/f3cea0fce1e0
Status: REOPENED → RESOLVED
Last Resolved: 4 months ago4 months ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.