1506198 - Re-investigate per-content process tempdirs

Status: RESOLVED FIXED

(Core :: Security: Process Sandboxing, enhancement, P2)

Description

[Gian-Carlo Pascutto [:gcp]]

We currently use a shared temporary directory, shared by all content processes.

After Fission, we want origins (sites?) to not be able to influence each other. So we should either:

a) Make this directory per-content-process.
b) Remove tempdir access entirely. This may be possible after WebGL and more font remoting.

Comment 1

[Gian-Carlo Pascutto [:gcp]]

Currently this is only an issue on Linux as the content temp dir was removed for other platforms: https://bugzilla.mozilla.org/show_bug.cgi?id=1772089

Comment 2

[Gian-Carlo Pascutto [:gcp]]

I can confirm that on current Ubuntu, there doesn't seem to be anything that needs to write to the content tmpdir any more.

Comment 3

[:gerard-majax]

Attachment: Bug 1506198 - Remove content temp dir r?gcp!

Comment 4

[Gian-Carlo Pascutto [:gcp]]

https://treeherder.mozilla.org/jobs?repo=try&revision=45a23d311b9cdd59a5199d4c208cb418a019975a&selectedTaskRun=Lxop6uAjR2mCyVJq37l9vw.0

At least some WebGL tests fail on Wayland, because they're trying to use EGL from content and crash when the tempdir isn't there for caches. They shouldn't do that :P

Comment 5

[:gerard-majax]

Now that bug 1750820 landed, the try is better: https://treeherder.mozilla.org/jobs?repo=try&revision=440ab7a6ad71c8b2bed97f418678632b45f5cb57
We have a bunch of failures on a sandbox test that was verifying this feature, so this is expected, I left it to make sure.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b38b6b47c602
Remove content temp dir r=gcp

Comment 7

[Norisz Fay [:noriszfay]]

Backed out for causing bustage on SandboxBroker.cpp

Backout link

Push with failures

Failure log

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e6478cf6aa10
Remove content temp dir r=gcp

Comment 9

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/e6478cf6aa10