1506230 - [Track Changes] Changes performed before initializing the Changes tab will not get tracked

Status: RESOLVED FIXED

(DevTools :: Inspector, defect, P1)

Description

[Paul_B]

Attachment: Short video of the issue

[Precondition]

Navigate to about:config and enable the Changes feat. ( devtools.inspector.changes.enabled - True) 

[STR]

1. Launch Firefox and enable the Inspector.
2. Make sure Changes tab is not focused when the Inspector is enabled. (If it is, just change the focus to a different 3rd pane tab, close the inspector end re-enable).
3. Perform any change. (edit property names / values / add rules / delete rules / disable rules / Font Changes ).
4. Navigate to Changes tab. 


[AR]
None of the changes performed are recorded in the Changes tab. 
I've added a short video for better understanding.

[ER]
Changes are tracked even if the Changes tab is not in focus.

Comment 1

[Razvan Caliman [:rcaliman]]

Attachment: Changes pane not open by default.mp4

I can't reproduce this issue using a simplified test case, as shown in the attached video. Perhaps the issue stems from some other interaction in the multitude of steps taken in the original video.

@Paul, can you please confirm if the issue still occurs in the simplified test case?

STR:

- Open Inspector & ensure Changes is default sidebar panel
- Select another sidebar panel
- Close Inspector (do not refresh page)
- Open Inspector again and make changes in the Rules view
- Switch to Changes sidebar panel

Comment 2

[Razvan Caliman [:rcaliman]]

Attachment: Changes pane not open by default (simplified).mp4

Sorry, I got a bit confused. These are the steps to reproduce for the simplified test case:

- Open Inspector & ensure Changes is not the default sidebar panel
- Make changes in the Rules view
- Switch to Changes sidebar panel

The previous steps to reproduce mirror the beginning of the workflow from the original video which still didn't replicate for me, but could have **favorably** influenced the test case by opening/closing the Inspector in the same session. This set of steps is a really simplified test case for the issue description.

Comment 3

[Razvan Caliman [:rcaliman]]

Found the root cause: this issue is a side-effect that happens when the pref is in the `false` state. 
This main issue is tracked in bug 1506903.

The precondition on this bug should be:
Navigate to about:config and **disable** the Changes feat. ( devtools.inspector.changes.enabled - false)

Comment 4

[Razvan Caliman [:rcaliman]]

Solved by fix for bug 1506903.